Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose Winit's with_skip_taskbar on window creation #12450

Merged
merged 4 commits into from Mar 18, 2024
Merged

Expose Winit's with_skip_taskbar on window creation #12450

merged 4 commits into from Mar 18, 2024

Conversation

chompaa
Copy link
Contributor

@chompaa chompaa commented Mar 12, 2024 •
edited

Objective

Resolves #12431.

Solution

Added a skip_taskbar field to the Window struct (defaults to false). Used in create_windows if the target OS is Windows.

@mockersf mockersf added A-Windowing Platform-agnostic interface layer to run your app in O-Windows Specific to the Windows desktop operating system labels Mar 12, 2024
@chompaa
Copy link
Contributor Author

chompaa commented Mar 13, 2024 •
edited

@mockersf Should be resolved now, not sure how I missed that import 😅, thanks!

mockersf
mockersf approved these changes Mar 13, 2024
View reviewed changes
Copy link
Member

@mockersf mockersf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't test, but it should do what it says

@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Mar 17, 2024
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Mar 18, 2024
Merged via the queue into bevyengine:main with commit adb8669 Mar 18, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afonsolage afonsolage afonsolage approved these changes

@mockersf mockersf mockersf approved these changes

Assignees
No one assigned
Labels
A-Windowing Platform-agnostic interface layer to run your app in O-Windows Specific to the Windows desktop operating system S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Expose Winit's with_skip_taskbar on window creation
4 participants
@chompaa @afonsolage @mockersf @alice-i-cecile