Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix z scale being 0.0 in breakout example #12439

Merged
merged 1 commit into from Mar 13, 2024
Merged

Fix z scale being 0.0 in breakout example #12439

merged 1 commit into from Mar 13, 2024

Conversation

rparrett
Copy link
Contributor

@rparrett rparrett commented Mar 12, 2024 •
edited

Objective

Scaling z by anything but 1.0 in 2d can only lead to bugs and confusion. See #4149.

Solution

Use a Vec2 for the paddle size const, and add a scale of 1.0 later. This matches the way BRICK_SIZE is defined.

@mockersf mockersf added C-Examples An addition or correction to our examples C-Code-Quality A section of code that is hard to understand or change labels Mar 12, 2024
@james7132 james7132 added this pull request to the merge queue Mar 13, 2024
Merged via the queue into bevyengine:main with commit a9ca849 Mar 13, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@james7132 james7132 james7132 approved these changes

@mockersf mockersf mockersf approved these changes

Assignees
No one assigned
Labels
C-Code-Quality A section of code that is hard to understand or change C-Examples An addition or correction to our examples
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rparrett @james7132 @mockersf