Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

low_power example: pick nits #12437

Merged
merged 2 commits into from Mar 12, 2024
Merged

low_power example: pick nits #12437

merged 2 commits into from Mar 12, 2024

Conversation

awwsmm
Copy link
Contributor

@awwsmm awwsmm commented Mar 12, 2024

Objective

  • no-longer-extant type WinitConfig referenced in comments
  • mouse_button_input refers to KeyCode input
  • "spacebar" flagged as a typo by RustRover IDE

Solution

  • replace WinitConfig with WinitSettings in comments
  • rename mouse_button_input to just button_input
  • change "spacebar" to "space bar"

@rparrett rparrett added C-Examples An addition or correction to our examples C-Code-Quality A section of code that is hard to understand or change labels Mar 12, 2024
@awwsmm
WinitConfig -> WinitSettings in docs, mouse_button_input -> button_in…
54b3653 
…put, spacebar -> space bar
@awwsmm
Update examples/window/low_power.rs
50887ac 
fixed out-of-date comment on unfocused_mode behaviour for Game mode
@awwsmm awwsmm force-pushed the example-low_power-fix-nits branch from 4f463c1 to 50887ac Compare March 12, 2024 21:50
@awwsmm
Copy link
Contributor Author

awwsmm commented Mar 12, 2024

☝🏻 updated main on my fork and rebased

@mockersf mockersf added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Mar 12, 2024
@mockersf mockersf added this pull request to the merge queue Mar 12, 2024
Merged via the queue into bevyengine:main with commit 3f6300d Mar 12, 2024
26 checks passed
@awwsmm awwsmm deleted the example-low_power-fix-nits branch March 13, 2024 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rparrett rparrett rparrett approved these changes

@mockersf mockersf mockersf approved these changes

Assignees
No one assigned
Labels
C-Code-Quality A section of code that is hard to understand or change C-Examples An addition or correction to our examples S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@awwsmm @rparrett @mockersf