Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix deprecations from toml_edit #12421

Merged
merged 3 commits into from Mar 11, 2024
Merged

fix deprecations from toml_edit #12421

merged 3 commits into from Mar 11, 2024

Conversation

mockersf
Copy link
Member

Objective

  • toml_edit released a new patch that deprecates Document
  • this warns when Bevy builds, and CI deny warns

Solution

  • fix deprecation warnings

@mockersf mockersf added A-Diagnostics Logging, crash handling, error reporting and performance analysis P-High This is particularly urgent, and deserves immediate attention labels Mar 11, 2024
@mockersf mockersf added this pull request to the merge queue Mar 11, 2024
@mockersf mockersf added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Mar 11, 2024
@james7132 james7132 added this to the 0.13.1 milestone Mar 11, 2024
Merged via the queue into bevyengine:main with commit b3655a3 Mar 11, 2024
30 checks passed
@mockersf mockersf removed this from the 0.13.1 milestone Mar 13, 2024
@mockersf
Copy link
Member Author

removing from the 0.13.1: it's depending on toml_edit 0.21 so shouldn't be affected

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aceeri Aceeri Aceeri approved these changes

@pablo-lua pablo-lua pablo-lua approved these changes

Assignees
No one assigned
Labels
A-Diagnostics Logging, crash handling, error reporting and performance analysis P-High This is particularly urgent, and deserves immediate attention S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mockersf @Aceeri @pablo-lua @james7132