Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI testing: don't crash if screenshot manager resource is not available #12385

Merged
merged 1 commit into from Mar 8, 2024
Merged

CI testing: don't crash if screenshot manager resource is not available #12385

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
12 changes: 9 additions & 3 deletions crates/bevy_dev_tools/src/ci_testing.rs
View file
Open in desktop
Expand Up @@ -3,8 +3,9 @@
use bevy_app::{App, AppExit, Update};
use bevy_ecs::{
entity::Entity,
prelude::Resource,
prelude::{resource_exists, Resource},
query::With,
schedule::IntoSystemConfigs,
system::{Local, Query, Res, ResMut},
};
use bevy_render::view::screenshot::ScreenshotManager;
Expand Down Expand Up @@ -67,8 +68,13 @@ pub(crate) fn setup_app(app: &mut App) -> &mut App {
)));
}

app.insert_resource(config)
.add_systems(Update, (ci_testing_exit_after, ci_testing_screenshot_at));
app.insert_resource(config).add_systems(
Update,
(
ci_testing_exit_after,
ci_testing_screenshot_at.run_if(resource_exists::<ScreenshotManager>),
),
);

app
}
Expand Down