Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix minimal plugins in ci #12370

Merged
merged 2 commits into from Mar 7, 2024
Merged

Fix minimal plugins in ci #12370

merged 2 commits into from Mar 7, 2024

Conversation

mockersf
Copy link
Member

@mockersf mockersf commented Mar 7, 2024

Objective

Solution

  • include DevToolsPlugin in MinimalPlugins

@mockersf mockersf added C-Bug An unexpected or incorrect behavior A-Build-System Related to build systems or continuous integration labels Mar 7, 2024
@alice-i-cecile
Copy link
Member

@matiqo15 can I get your review here?

@alice-i-cecile alice-i-cecile added this pull request to the merge queue Mar 7, 2024
@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Mar 7, 2024
Merged via the queue into bevyengine:main with commit 0baedcf Mar 7, 2024
29 checks passed
@mockersf mockersf mentioned this pull request Mar 8, 2024
Merged
github-merge-queue bot pushed a commit that referenced this pull request Mar 8, 2024
@mockersf
CI testing: don't crash if screenshot manager resource is not availab…
8e467f4 
…le (#12385)

# Objective

- After #12370, ci testing with minimal plugins doesn't hang but it
crash as the resource `ScreenshotManager` doesn't exist

## Solution

- Check if the resource exists
spectria-limina pushed a commit to spectria-limina/bevy that referenced this pull request Mar 9, 2024
@mockersf @spectria-limina
Fix minimal plugins in ci (bevyengine#12370)
ec88110 
# Objective

- bevyengine#11341 broke running code using `MinimalPlugins` in CI

## Solution

- include `DevToolsPlugin` in `MinimalPlugins`
spectria-limina pushed a commit to spectria-limina/bevy that referenced this pull request Mar 9, 2024
@mockersf @spectria-limina
CI testing: don't crash if screenshot manager resource is not availab…
4a1d0dd 
…le (bevyengine#12385)

# Objective

- After bevyengine#12370, ci testing with minimal plugins doesn't hang but it
crash as the resource `ScreenshotManager` doesn't exist

## Solution

- Check if the resource exists
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kristoff3r kristoff3r kristoff3r approved these changes

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@matiqo15 matiqo15 Awaiting requested review from matiqo15

Assignees
No one assigned
Labels
A-Build-System Related to build systems or continuous integration C-Bug An unexpected or incorrect behavior S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mockersf @alice-i-cecile @kristoff3r