Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve gizmo axes example #12335

Merged
merged 2 commits into from Mar 8, 2024
Merged

Improve gizmo axes example #12335

merged 2 commits into from Mar 8, 2024

Conversation

mockersf
Copy link
Member

@mockersf mockersf commented Mar 6, 2024

Objective

Solution

  • Transitions between transforms will take 2 seconds instead of 100 frames
  • Random is seeded

@mockersf mockersf added C-Examples An addition or correction to our examples A-Gizmos Visual editor and debug gizmos labels Mar 6, 2024
pablo-lua
pablo-lua approved these changes Mar 7, 2024
View reviewed changes
Copy link
Contributor

@pablo-lua pablo-lua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a maybe silly question here, but good changes, all good.

examples/gizmos/axes.rs Show resolved Hide resolved
@mockersf mockersf added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Mar 8, 2024
@mockersf mockersf added this pull request to the merge queue Mar 8, 2024
Merged via the queue into bevyengine:main with commit 7546624 Mar 8, 2024
29 checks passed
spectria-limina pushed a commit to spectria-limina/bevy that referenced this pull request Mar 9, 2024
@mockersf @spectria-limina
Improve gizmo axes example (bevyengine#12335)
8624f1f 
# Objective

- Improve example from bevyengine#12299 
- Make it frame rate independent
- Make it not randomly random

## Solution

- Transitions between transforms will take 2 seconds instead of 100
frames
- Random is seeded
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doonv doonv doonv approved these changes

@pablo-lua pablo-lua pablo-lua approved these changes

Assignees
No one assigned
Labels
A-Gizmos Visual editor and debug gizmos C-Examples An addition or correction to our examples S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mockersf @doonv @pablo-lua