Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

don't depend directly on oboe #12316

Merged
merged 1 commit into from Mar 5, 2024
Merged

don't depend directly on oboe #12316

merged 1 commit into from Mar 5, 2024

Conversation

mockersf
Copy link
Member

@mockersf mockersf commented Mar 5, 2024

Objective

  • Avoid version mismatch
  • When cpal updates oboe in a patch release, this breaks android support for Bevy

Solution

  • Use the same version of oboe as cpal by relying on it to re-export the feature

@mockersf mockersf added A-Audio Sounds playback and modification O-Android Specific to the Android mobile operating system labels Mar 5, 2024
@mockersf mockersf added this to the 0.13.1 milestone Mar 5, 2024
@mockersf mockersf added the C-Dependencies A change to the crates that Bevy depends on label Mar 5, 2024
@james7132 james7132 added this pull request to the merge queue Mar 5, 2024
Merged via the queue into bevyengine:main with commit 212dc60 Mar 5, 2024
33 checks passed
mockersf added a commit that referenced this pull request Mar 5, 2024
@mockersf
don't depend directly on oboe (#12316)
7f9ebfd 
- Avoid version mismatch
- When cpal updates oboe in a patch release, this breaks android support
for Bevy

- Use the same version of oboe as cpal by relying on it to re-export the
feature
spectria-limina pushed a commit to spectria-limina/bevy that referenced this pull request Mar 9, 2024
@mockersf @spectria-limina
don't depend directly on oboe (bevyengine#12316)
026d119 
# Objective

- Avoid version mismatch
- When cpal updates oboe in a patch release, this breaks android support
for Bevy

## Solution

- Use the same version of oboe as cpal by relying on it to re-export the
feature
@mockersf mockersf mentioned this pull request Mar 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@james7132 james7132 james7132 approved these changes

@pablo-lua pablo-lua pablo-lua approved these changes

Assignees
No one assigned
Labels
A-Audio Sounds playback and modification C-Dependencies A change to the crates that Bevy depends on O-Android Specific to the Android mobile operating system
Projects
Audio
Status: Done
Milestone
0.13.1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mockersf @james7132 @pablo-lua