Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bloom: use emissive instead of base_color for emissive #12220

Merged
merged 1 commit into from Mar 1, 2024
Merged

bloom: use emissive instead of base_color for emissive #12220

merged 1 commit into from Mar 1, 2024

Conversation

mockersf
Copy link
Member

@mockersf mockersf commented Mar 1, 2024 •
edited

Objective

Solution

  • Fix a copy paste mistake and use emissive for the emissive

@mockersf mockersf added C-Bug An unexpected or incorrect behavior A-Rendering Drawing game state to the screen labels Mar 1, 2024
@rparrett
Copy link
Contributor

rparrett commented Mar 1, 2024

This explains a lot of the subtle visual changes after #12163 -- all materials have become slightly emissive!

Good catch.

@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Mar 1, 2024
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Mar 1, 2024
Merged via the queue into bevyengine:main with commit 4aca55d Mar 1, 2024
29 checks passed
spectria-limina pushed a commit to spectria-limina/bevy that referenced this pull request Mar 9, 2024
@mockersf @spectria-limina
bloom: use emissive instead of base_color for emissive (bevyengine#12220
aa85f9c 
)

# Objective

- bloom is not working anymore in 3d after
bevyengine#12163

## Solution

- Fix a copy paste mistake and use emissive for the emissive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rparrett rparrett rparrett approved these changes

@afonsolage afonsolage afonsolage approved these changes

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mockersf @rparrett @afonsolage @alice-i-cecile