load application from factory function #2178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use `ast.parse` to validate that the string passed to the CLI is either an attribute name or a function call. Use `ast.literal_eval` to parse any positional and keyword arguments to the function. Call the function to get the real application. Co-authored-by: Connor Brinton <connor.brinton@gmail.com>
|
@benoitc I was going to add a news entry, but couldn't figure out where to add it. There's no section for the next 20.x version, and the |
|
sounds good for me. I will do some tests this afternoon. Thanks for the patch! |
benoitc
approved these changes
Nov 19, 2019
benoitc
pushed a commit
that referenced
this pull request
Nov 19, 2019
* load application from factory function Use `ast.parse` to validate that the string passed to the CLI is either an attribute name or a function call. Use `ast.literal_eval` to parse any positional and keyword arguments to the function. Call the function to get the real application. Co-authored-by: Connor Brinton <connor.brinton@gmail.com> * test coverage for util.import_app * document app factory pattern
|
Thank you so much for the help on this. |
|
@davidism sorry I missed your message. The changes should be added to https://github.com/benoitc/gunicorn/blob/master/docs/source/news.rst also I don't link anymore to issues or ids now since it makes the changes history too much dependent of Github. So a change is a line describing the change. Rest of the history must be in git :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
ast.parseto validate that the string passed to the CLI is either an attribute name or a function call. Useast.literal_evalto parse positional and keyword arguments to the function. Call the function to get the real application.fixes #2159
Todo: