Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ast.parse to validate FLASK_APP #3553

Closed
davidism opened this issue Apr 4, 2020 · 0 comments · Fixed by #3564
Closed

Use ast.parse to validate FLASK_APP #3553

davidism opened this issue Apr 4, 2020 · 0 comments · Fixed by #3564
Assignees
@davidism
Labels
cli
Milestone
2.0.0

Comments

@davidism
Copy link
Member

davidism commented Apr 4, 2020

I wrote this for Gunicorn a while ago: benoitc/gunicorn#2178. It would be good to use it for Flask too, it's the same use case. Right now we use some regex and string manipulation to validate and prepare for ast.literal_eval, but ast.parse is the correct way to do it.
@davidism davidism added the cli label Apr 4, 2020
@davidism davidism added this to the 2.0.0 milestone Apr 4, 2020
@davidism davidism self-assigned this Apr 4, 2020
@davidism davidism mentioned this issue Apr 8, 2020
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@davidism davidism

Labels
cli
Projects
None yet
Milestone
2.0.0
Development

Successfully merging a pull request may close this issue.

use ast to parse FLASK_APP pallets/flask
1 participant
@davidism