New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Summary can't find the samples #509
Comments
Hi @andreaniml Good news I know the issue for the both of these. The issue with the bactopia summary is related to changes I made to do with this #487 You are correct! Panaroo is related to this #507 For bactopia summary, I also ran into this and will get the fix into bactopia-py. And for Panaroo, it should just require a rebuild of the dev environment. I can update soon one the bactopia summary fix. Thank you letting me know about these! |
Hi! I tried using the dev build, but I faced the same problem while trying to use wf pangenome
|
Awesome, I can see the new syntax in the error message. There seems to be a lingering "true" value in there. Let me dig into this and I will update soon |
If it helps, I tried using the "--remove-invalid-genes" option from panaroo pipeline. I may have got the syntax of the command line wrong, but I think that it tries to give a "true" value to "--panaroo_opts" instead of passing the option itself. |
Could you try |
Looks like it worked! (At least it is running. I will report back when it finishes) For the bactopia summary, should I clone the bactopia-py repo? |
Cool keep me posted on the panaroo bit, if that's the fix I'll be sure to update docs to highlight the need for the for bactopia-py, I'll get that fixed this morning and update soon |
OK! I think this is fixed:
With fixes
I will get a release out on bactopia-py, then update the bactopia recipe |
This should now be fixed in dev build |
Hi Robert! unfortunately, I am still getting the same bug
running with the --force flag still gets me the error |
Can you run with |
Here
It thinks I used prokka and now amrfinder outputs two tsv instead of one
and
|
Oh! 🤦 Let me check to see if it's because I don't check for bakta outputs! |
Ok! I think this is now fixed in the latest dev version and bactopia-py 1.1.1 Try a rebuild and make sure bactopia summary is v1.1.1
Thank you for bringing this to my attention! |
Hi ! Almost there, it now can take the bakta output, but it still complains on the amrfinderplus samples where there are two files instead of one. It tries to find:
|
Hmmm we have an issue here, bactopia-py no longer supports 2 file AMRFinder results, and the old version which does, does not support bakta. One simple solution would be to rerun amrfinder plus this would get you the single file output
|
Oh, will try this. Thank you very much for all the help! |
Ok, it seems that there may be a problem with my amrfinder.
I tried building a new bactopia-dev, and got the same error, tried specifying another directory and got the same error. Checking the .nextflow.log it seems that something gets to run (if I check the work directory, there are files), I am not sure which part of the log could be of use, I suspect is this one (but I can upload the whole file if necessary).
|
Look for I suspect this is going to be something related to gff and mismatching contigs names |
you are right!
I think that bakta does change the name of the contigs automatically (I should have used the option to keep the contig names but forgot), is there anything I can do? |
Let me look into this, I saw this earlier on some of my samples and was hoping it was just the way I ran them. Did you originally run the samples with Bakta? Or run it as a bactopia tool? |
I originally ran the main pipeline, using the "--use_bakta" flag |
great I ran my the same, I will take a look now and see if I can get it figure out |
I am not sure if it works like that, but I think that bakta renames the contigs to "contig_1","contig_2" and so on. Maybe if amrfinder was able to look at the fasta headers of the .fna file it could be normalized? (I want to think that the contigs stay in the same order in the gff and fna, but don't know) I think that probably the easiest way it to rerrun everything with the "--keep-contig-headers" option (bactopia can take additional options for bakta, right?), but I'll leave the thought |
I think I got a fix in place: d80eece haha I will once again ask you to rebuild your dev environment So you are correct on what is happening. in the bactopia main pipeline, amrfinder gets the assembly, proteins and gff from either prokka or bakta In the bactopia-tools, amrfinder gets the assembly from shovill or dragonflye, and the proteins and gff from prokka or bakta In the above commit, I make sure amrfinder gets the assembly from prokka/bakta. With a quick test on my end, the error went away |
Oh nice! Will rebuild here! |
I think we got that back working, haha we'll wait to see on bactopia-summary! |
It worked!!!
Thanks a lot for all the help! |
Awesome! Thank you so much for your patience and help in getting this all sorted out! |
Description
I was able to run the main pipeline, I used bakta as an annotator instead of prokka
I am not able to run neither summary command or the pangenome workflow using panaroo. I think it is a bug similar to the issue open for PIRATE (#507), it is having problems to find the samples.
Steps to Reproduce
Steps to reproduce the behavior for panaroo:
Steps for reproduce panaroo bug
Expected Behavior
Files for bactocpia summary and report being created
Panaroo output being created
Execution Environment
The text was updated successfully, but these errors were encountered: