Adapt to latest lazy loading of Monaco editor #515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
new inscription view version is published to our repo |
- Trigger Monaco loading as early as possible but do not await - Replace temporary Monaco promise - Add loading spinner to standalone variant Co-authored-by: Olaf Lessenich <olessenich@eclipsesource.com>
martin-fleck-at
force-pushed
the
features/lazy-loading
branch
from
5d8e2ce
to
ac8b42d
Compare
|
@ivy-lli I pushed an update to the versions, could you trigger the tests? They seemed to have issues before but maybe it was due to the wrong versions being used. However, I don't see if the update re-triggered the CI. |
|
@martin-fleck-at tests seems to be good, should I merge? |
|
Yeah, I think we can merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires axonivy/inscription-client#532