Improve lazy loading of Monaco editor and fix webworker warning #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivy-lli
approved these changes
Mar 20, 2024
|
@martin-fleck-at new version of the process editor packages should be in the npm repo |
|
@ivy-lli Thank you, I'll update this PR very soon! |
|
@martin-fleck-at Did you update this PR? Because it seems to work now :) Can you maybe update the @axonivy dependencies in the package.json/.lock? |
|
@ivy-lli I have triggered the jobs |
- Load web worker through blob URL - Avoid scripts from being loaded automatically if they are dynamic Co-authored-by: Olaf Lessenich <olessenich@eclipsesource.com>
martin-fleck-at
force-pushed
the
features/lazy-loading
branch
from
890626e
to
77de058
Compare
|
I only updated the |
|
The PR looks good and the builds are happy. I will merge :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires axonivy/process-editor-client#515