Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add download url of yolox with semantic segmentation header #4012

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

badai-nguyen
Copy link
Contributor

@badai-nguyen badai-nguyen commented Nov 21, 2023

Description

This PR to add yolox-s model with semantic segmentation to solve the issue autowarefoundation/autoware.universe#5594
This should be merged before autowarefoundation/autoware.universe#5553.

Related link

TIER IV INTERNAL LINK

Tests performed

Test ./setup-dev-env.sh on local machine and get successful to download the desired files:
image

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@badai-nguyen
Copy link
Contributor Author

Since @dan-dnn is plan to update the yolox model so I convert this to PR and reopen when the model is ready

@badai-nguyen badai-nguyen marked this pull request as draft December 8, 2023 02:10
@esteve esteve self-requested a review December 11, 2023 08:27
@esteve
Copy link
Contributor

esteve commented Dec 11, 2023

@badai-nguyen no problem, thanks for the update

@xmfcx xmfcx added component:perception Advanced sensor data processing and environment understanding. type:installation Issues or improvements related to the installation process of the software. labels Dec 11, 2023
Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
@badai-nguyen badai-nguyen force-pushed the fix/add_semseg_yolox_download_url branch from 8916162 to 1f4d5d6 Compare May 24, 2024 10:01
@badai-nguyen badai-nguyen requested a review from YoshiRi May 24, 2024 10:03
@badai-nguyen badai-nguyen marked this pull request as ready for review May 24, 2024 10:03
@badai-nguyen badai-nguyen removed the request for review from wep21 May 24, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. type:installation Issues or improvements related to the installation process of the software.
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants