Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving file manager to manage course #2154

Merged
merged 5 commits into from
May 4, 2024
Merged

Conversation

KesterTan
Copy link
Contributor

@KesterTan KesterTan commented May 1, 2024

Instructors can't access file manager from manage autolab dropdown since they are not all administrators.

Moved File Manager to manage course.

How Has This Been Tested?

  • Check that file manager can be accessed after clicking manage course
  • File manager cannot be accessed from manage autolab dropdown
  • Clicking file manager directly opens up file manager for the course

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have run rubocop and erblint for style check. If you haven't, run overcommit --install && overcommit --sign to use pre-commit hook for linting
  • My change requires a change to the documentation, which is located at Autolab Docs
  • I have updated the documentation accordingly, included in this PR

Summary by CodeRabbit

  • New Features

    • Added a new link to "File Manager" in the course management view for easier access.
  • Documentation

    • Updated the instructor documentation to reflect the new access path to the File Manager feature.
  • Style

    • Removed outdated links to "File Manager" from the navigation bar to streamline navigation.

Copy link
Contributor

coderabbitai bot commented May 1, 2024

Walkthrough

Walkthrough

The recent updates aim to streamline access to the "File Manager" feature. A direct link to the File Manager has been added to the course management view, enhancing user convenience. Simultaneously, links to the File Manager have been removed from the navigation bar to declutter the interface. Documentation adjustments now guide users effectively to the revised access pathway for the File Manager feature.

Changes

File Path Change Summary
.../courses/manage.html.erb
.../layouts/_navbar.html.erb
Added a link to "File Manager" in the course management view and removed links to "File Manager" from the navigation bar.
docs/instructors.md Updated documentation to reflect the new access path to the File Manager.
app/controllers/file_manager_controller.rb Modified the populate_directory method to remove the CGI.unescape method call for the relative attribute assignment.
config/routes.rb Renamed route helpers for various HTTP methods to more concise names while maintaining controller action mappings with path constraints.

Recent Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between 721304d and 6bcf22f.
Files selected for processing (2)
  • app/controllers/file_manager_controller.rb (1 hunks)
  • config/routes.rb (1 hunks)
Files skipped from review due to trivial changes (1)
  • app/controllers/file_manager_controller.rb
Files skipped from review as they are similar to previous changes (1)
  • config/routes.rb

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Out of diff range and nitpick comments (1)
docs/instructors.md (1)

Line range hint 185-203: Ensure consistent use of list item markers in Markdown.

- - You cannot create folders or upload files in the root Courses directory. To create a course, you should navigate to Create New Course via the Manage Autolab dropdown.
+ * You cannot create folders or upload files in the root Courses directory. To create a course, you should navigate to Create New Course via the Manage Autolab dropdown.
- - You cannot rename files in the root Courses directory. To rename a course, you should navigate to the course, click Manage Course, and click Course Settings.
+ * You cannot rename files in the root Courses directory. To rename a course, you should navigate to the course, click Manage Course, and click Course Settings.
- - You cannot upload files that are larger than 1 GB.
+ * You cannot upload files that are larger than 1 GB.
- - You cannot create a folder or upload a file with a name that already exists.
+ * You cannot create a folder or upload a file with a name that already exists.
- - Deleting a folder will also delete all of its contents.
+ * Deleting a folder will also delete all of its contents.
- - Downloading a folder will create a tar with all of its contents.
+ * Downloading a folder will create a tar with all of its contents.
- - Download Selected downloads each of the selected files/folders separately.
+ * Download Selected downloads each of the selected files/folders separately.
- - When clicking on a file, it will be automatically downloaded if it is larger than 1GB or a binary file. Otherwise, the file contents will be displayed.
+ * When clicking on a file, it will be automatically downloaded if it is larger than 1GB or a binary file. Otherwise, the file contents will be displayed.

app/views/courses/manage.html.erb Outdated Show resolved Hide resolved
@KesterTan KesterTan requested a review from damianhxy May 1, 2024 18:44
@damianhxy
Copy link
Member

LGTM

@KesterTan KesterTan added this pull request to the merge queue May 4, 2024
Merged via the queue into master with commit ba32ae1 May 4, 2024
5 checks passed
@KesterTan KesterTan deleted the file_manager_manage_course branch May 4, 2024 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants