Moving file manager to manage course (#2154)

* File manager moved to manage course

* Index directly into folder of course

* Erblint

* Shorten path name

* Shortened names of other routes

app/controllers/file_manager_controller.rb

@@ -197,7 +197,7 @@ def populate_directory(current_directory, current_url)
         rescue StandardError
           '-'
         end,
-        relative: CGI.unescape("/file_manager/#{new_url}#{file}"),
+        relative: "/file_manager/#{new_url}#{file}",
         entry: "#{file}#{is_file ? '' : '/'}",
         absolute: abs_path_str,
         instructor: inst,

app/views/courses/manage.html.erb

@@ -62,6 +62,9 @@
               <%= link_to "Export course", export_course_path(@course),
                           { title: "Export course configurations and assessments" } %>
             </li>
+            <li>
+              <%= link_to "File Manager", path_file_manager_index_path(@course.name), { title: "File manager" } %>
+            </li>
 
             <li class="collection-item red-text danger-bottom no-hover"><h4>Danger Zone</h4></li>
             <li class="danger-side">

app/views/layouts/_navbar.html.erb

@@ -62,8 +62,6 @@
 
       <li role="presentation"><%= link_to "Clear Cache", clear_cache_admin_url,
                                           title: "Clear Cache", data: { method: "post" } %></li>
-
-      <li role="presentation"><%= link_to "File Manager", file_manager_index_path, title: "File manager" %></li>
     </ul>
   <% end %>
 
@@ -83,8 +81,6 @@
       <li role="presentation"><%= link_to "Configure Autolab", autolab_config_admin_path, title: "Configure Autolab settings" %></li>
 
       <li role="presentation"><%= link_to "Clear Cache", clear_cache_admin_url, title: "Clear Cache", data: { method: "post" } %></li>
-
-      <li role="presentation"><%= link_to "File Manager", file_manager_index_path, title: "File manager" %></li>
     </ul>
   <% end %>
 

config/routes.rb

@@ -76,10 +76,10 @@
       post 'upload', to: 'file_manager#upload'
       post '/', to: 'file_manager#upload'
       post 'download_tar', to: 'file_manager#download_tar'
-      get ':path', to: 'file_manager#index', constraints: { path: /.+/ }, as: :path_file_manager
-      put ':path', to: 'file_manager#rename', constraints: { path: /.+/ }, as: :rename_file_manager
-      post ':path', to: 'file_manager#upload', constraints: { path: /.+/ }, as: :upload_file_manager
-      delete ':path', to: 'file_manager#delete', constraints: { path: /.+/ }, as: :delete_file_manager
+      get ':path', to: 'file_manager#index', constraints: { path: /.+/ }, as: :path
+      put ':path', to: 'file_manager#rename', constraints: { path: /.+/ }, as: :rename
+      post ':path', to: 'file_manager#upload', constraints: { path: /.+/ }, as: :upload_path
+      delete ':path', to: 'file_manager#delete', constraints: { path: /.+/ }, as: :delete
     end
   end
 

docs/instructors.md

@@ -182,7 +182,7 @@ Displays files within a course and allows you to rename, delete, and add files a
 
 You can view all courses that you are an instructor of and all associated files.
 
-You can access the File Manager via the Manage Autolab dropdown.
+You can access the File Manager under Admin Course after clicking Manage Course.
 
 Note: