Make short_weierstrass::Affine's infinity flag conditional
#639
+81
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pratyush
requested review from
mmagician and
weikengchen
and removed request for
a team
|
Note that I'm not sure this is necessarily a change that we want: the resulting UX is worse (implementors of For the first issue, maybe we can provide a macro or something that automatically makes the choice for end users. For the second issue, we should benchmark and see if there's perf differences. |
Pratyush
commented
Apr 21, 2023
| @@ -30,6 +33,9 @@ pub trait SWCurveConfig: super::CurveConfig { | |||
| /// Generator of the prime-order subgroup. | |||
| const GENERATOR: Affine<Self>; | |||
|
|
|||
| /// A type that is stored in `Affine<Self>` to indicate whether the point is at infinity. | |||
| type ZeroIndicator: ZeroInd<Self>; | |||
There was a problem hiding this comment.
Not really happy with this name; happy to take suggestions for better name.
Pratyush
commented
Apr 21, 2023
| @@ -198,3 +204,30 @@ pub trait SWCurveConfig: super::CurveConfig { | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| pub trait ZeroInd<C: SWCurveConfig>: | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR allows
short_weierstrass::Affine's layout to conditionally contain aboolflag indicating whether or not it is zero. This is helpful for compressing the representation of the point in memory. Note that due to the unfortunate lack of associated type defaults, we cannot set the type of the flag to beboolby default.In the future, it would be nice to automatically derive this from certain conditions (e.g.,
A.is_zero())Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
Pendingsection inCHANGELOG.mdFiles changedin the GitHub PR explorer