Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ark-vesta uses a different point encoding than pasta_curves #768

Open
mmaker opened this issue Jan 31, 2024 · 2 comments
Open

ark-vesta uses a different point encoding than pasta_curves #768

mmaker opened this issue Jan 31, 2024 · 2 comments

Comments

@mmaker
Copy link
Member

mmaker commented Jan 31, 2024

This test at line 92:

    assert_eq!(&ark_generator_bytes, &group_generator_bytes.as_ref());

fails with:


---- plugins::tests::test_compatible_pallas stdout ----
thread 'plugins::tests::test_compatible_pallas' panicked at src/plugins/tests.rs:92:5:
assertion `left == right` failed
  left: [0, 0, 0, 0, 33, 235, 70, 140, 221, 168, 148, 9, 252, 152, 70, 34, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 64, 0]
 right: [0, 0, 0, 0, 33, 235, 70, 140, 221, 168, 148, 9, 252, 152, 70, 34, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 64]
@slumber
Copy link
Contributor

slumber commented Jan 31, 2024

Doesn't #639 fix it?

@mmaker
Copy link
Member Author

mmaker commented Jan 31, 2024

I think the issue that you're point out concerns representation in memory, but here I'm trying to make sure that the byte representation is identical!

it seems the reason is similar, but over the serialize implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants