Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use pip install instead of deprecated python setup.py install command #2962

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use pip install instead of deprecated python setup.py install command #2962

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/py/Makefile.am
View file
Open in desktop
Expand Up @@ -45,7 +45,7 @@ all-local: py3-build
# Old version (can't put inline because it's not portable).
#$(PYTHON) setup.py install --prefix=$(prefix) --root=$(DESTDIR) $(PYTHON_SETUPUTIL_ARGS)
install-exec-hook:
$(PYTHON) setup.py install --root=$(DESTDIR) --prefix=$(PY_PREFIX) $(PYTHON_SETUPUTIL_ARGS)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we still need setup.py? or is it still used by pip?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's more background for it: https://blog.ganssle.io/articles/2021/10/setup-py-deprecated.html

There is a link to https://setuptools.pypa.io/en/latest/userguide/declarative_config.html

The short answer is: no, you probably don't need setup.py, and should probably be using setuptools' declarative config file, setup.cfg (if you need one at all).

$(PYTHON) -m pip install . --root=$(DESTDIR) --prefix=$(PY_PREFIX) $(PYTHON_SETUPUTIL_ARGS)

check-local: all py3-test
$(PYTHON) test/thrift_json.py
Expand Down