Use pip install instead of deprecated python setup.py install command #2962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fishy
reviewed
Apr 16, 2024
| @@ -45,7 +45,7 @@ all-local: py3-build | |||
| # Old version (can't put inline because it's not portable). | |||
| #$(PYTHON) setup.py install --prefix=$(prefix) --root=$(DESTDIR) $(PYTHON_SETUPUTIL_ARGS) | |||
| install-exec-hook: | |||
| $(PYTHON) setup.py install --root=$(DESTDIR) --prefix=$(PY_PREFIX) $(PYTHON_SETUPUTIL_ARGS) | |||
There was a problem hiding this comment.
do we still need setup.py? or is it still used by pip?
There was a problem hiding this comment.
Here's more background for it: https://blog.ganssle.io/articles/2021/10/setup-py-deprecated.html
There is a link to https://setuptools.pypa.io/en/latest/userguide/declarative_config.html
The short answer is: no, you probably don't need setup.py, and should probably be using setuptools' declarative config file, setup.cfg (if you need one at all).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use pip install instead of deprecated python setup.py install command.
Egg formats will be deprecated in pip v24.3 (planned for October). Users are required to use
pip installinstead.For reference : pypa/pip#12330