Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

THRIFT-5139/THRIFT-4181: Python3 type hints #2929

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

THRIFT-5139/THRIFT-4181: Python3 type hints #2929

wants to merge 3 commits into from

Commits on May 26, 2024

  1. Python3 type hints 

    args not optional type hint

UUID generator support

Remove runtime type check
    @arkuhn
    Konstantin Pozdniakov authored and arkuhn committed May 26, 2024
    Configuration menu
    Copy the full SHA
    04d5351 View commit details
    Browse the repository at this point in the history

  2. Update tests for type_hints

    @arkuhn
    arkuhn committed May 26, 2024
    Configuration menu
    Copy the full SHA
    b0e3aae View commit details
    Browse the repository at this point in the history

  3. Review comments 

    - Update flag description to be more precise
- No implict enum generation (gen enum flag required)
- Use latest thrift test IDL for uuid coverage
- rebase on latest main
    @arkuhn
    arkuhn committed May 26, 2024
    Configuration menu
    Copy the full SHA
    b8d0da3 View commit details
    Browse the repository at this point in the history