THRIFT-5139/THRIFT-4181: Python3 type hints #2929
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add type hinting and native enums (IntEnum) for python generated code
RunClientServer.py
andgenerate.cmake
.Note: Appveyor x86 / Python 3.5 build is failing since this PR generates variable type hints (
x: int = 1
), which are only python 3.6 and up. Do we have any patterns established for skipping tests based on platform/python version?Example difference in generated code after running
thrift --gen py:type_hints
against:ttypes.py
UnderscoreSrv.py
Unrelated to these changes, I noticed that even if a field is marked as required,
declare_argument
generates a default value in the function arguments of None.Open questions: Since the original PR opened,
[skip ci]
anywhere in the commit message to free up build resources.