New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(#2374): provide a framework to easily unit test processing elements #2730
Conversation
Thanks a lot for the PR and updating the old tests. I really appreciate your effort in improving the testing framework step by step. While reviewing the current version, I have some minor comments that I think could enhance the overall clarity and cleanliness of the codebase:
Please feel free to respond to the comments, especially if you have a different opinion. |
@tenthe Suggestions make sense to me. Made the updates |
@IsaakKrut, thanks for the changes. Furthermore, I would suggest to write a builder to create the @IsaakKrut, do you want to provide a suggestion for the design of such an API? |
64d2b94
into
apache:2374-provide-a-framework-to-easily-unit-test-processing-elements
* feat(#2374): Add suggestion to test processing elements * #2374 refactored unit tests to use ProcessingElementTestExecutor * #2374 cleanup * #2374 cleanup * #2374 updated test executor to non-static methods * #2374 updated test executor to non-static methods * test(#2374): provide a framework to easily unit test processing elements (#2730) * #2374 refactored unit tests to use ProcessingElementTestExecutor * #2374 cleanup * #2374 cleanup * #2374 updated test executor to non-static methods * #2374 updated test executor to non-static methods * #2374 Added test configuration builder and resolved selector prefixes * #2374 Moved test executor to a new package * feat(#2374): Fix cyclic dependencies and checkstyle * feat(#2374): Fix checkstyle * #2374 extracted TestConfigurationBuilder into a separate file --------- Co-authored-by: Isaak <krutisaak099@gmail.com>
Added a couple of features to the test executor.
Refactored all tests in streampipes-processors-filters-jvm to use the executor
PR introduces (a) breaking change(s): no
PR introduces (a) deprecation(s): no