Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit testing framework updates #2737

Closed
IsaakKrut opened this issue Apr 16, 2024 · 3 comments · Fixed by #2375
Closed

Unit testing framework updates #2737

IsaakKrut opened this issue Apr 16, 2024 · 3 comments · Fixed by #2375
Assignees
Labels
testing Relates to any kind of test (unit test, integration, or E2E test).
Milestone

Comments

@IsaakKrut
Copy link
Contributor

Body

Related to #2374

As discussed in PR #2730

  • Move ProcessingElementTestExecutor into the module streampipes-test-utils
  • Create a builder for userConfigurations parameter
  • Hide the prefixes inside userConfigurations

StreamPipes Committer

I acknowledge that I am a maintainer/committer of the Apache StreamPipes project.

@bossenti bossenti added this to the 0.97.0 milestone Apr 17, 2024
@bossenti bossenti added the testing Relates to any kind of test (unit test, integration, or E2E test). label Apr 17, 2024
@IsaakKrut
Copy link
Contributor Author

Hi @tenthe,

I pushed my changes to the branch apache:2374-provide-a-framework-to-easily-unit-test-processing-elements. I am having issues with moving the code to a different module. When I tried moving it to streampipes-test-utils I had errors with cyclic dependencies. I created a new module streampipes-test-utils-executors, but getting this error:
The following artifacts could not be resolved: org.apache.streampipes:streampipes-test-utils-executors:jar:tests:0.95.0-SNAPSHOT (absent): org.apache.streampipes:streampipes-test-utils-executors:jar:tests:0.95.0-SNAPSHOT was not found in https://repository.apache.org/snapshots

How should I proceed with that?

Regarding the functionality you can see commit c25b1be

All tests are working. I have identified 4 scenarios for the selector prefix:

  1. Default. By default the prefix will be an empty string
  2. SAME_PREFIX. Will use s0 for all events
  3. ALTERNATE. Will alternate between s0 and s1
  4. Custom. Accepts a list of prefixes that will be iterated over during event generation.

I assume after the issue with maven modules is fixed I can create a PR from 2374-provide-a-framework-to-easily-unit-test-processing-elements to the dev branch

@tenthe
Copy link
Contributor

tenthe commented Apr 25, 2024

Hi @IsaakKrut,

thank you for the changes.
I will have a look at them, but will take until next week.

Cheers,
Philipp

@bossenti bossenti linked a pull request May 2, 2024 that will close this issue
@bossenti
Copy link
Contributor

bossenti commented May 2, 2024

Closed by #2375

@bossenti bossenti closed this as completed May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Relates to any kind of test (unit test, integration, or E2E test).
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants