[SPARK-52771][PS] Fix float32 type widening in truediv/floordiv
#51456
+34
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xinrong-meng
changed the title
truediv/floordiv under ANSItruediv/floordiv
|
@ueshin may I get a review please? |
ueshin
approved these changes
Jul 21, 2025
|
Merged to master. |
haoyangeng-db
pushed a commit
to haoyangeng-db/apache-spark
that referenced
this pull request
Jul 22, 2025
### What changes were proposed in this pull request?
Fix float32 type widening in `truediv`/`floordiv` when ANSI on/off.
### Why are the changes needed?
Ensure pandas on Spark works well with ANSI mode on/off.
Note that the issue exists whether ANSI mode is on or off, as shown below,
```py
>>> pser = pd.Series([1.1, 2.2, 3.3], dtype=np.float32)
>>> psser = ps.from_pandas(pser)
>>> spark.conf.set("spark.sql.ansi.enabled", False)
>>> psser / 1
0 1.1
1 2.2
2 3.3
dtype: float64
>>> spark.conf.set("spark.sql.ansi.enabled", True)
>>> psser / 1
0 1.1
1 2.2
2 3.3
dtype: float64
```
### Does this PR introduce _any_ user-facing change?
Yes. truediv/floordiv under ANSI works as expected, with ANSI on/off, as shown below.
```py
>>> import pandas as pd
>>> import numpy as np
>>>
>>> ps.set_option("compute.fail_on_ansi_mode", False)
>>> ps.set_option("compute.ansi_mode_support", True)
>>>
>>> pser = pd.Series([1.1, 2.2, 3.3], dtype=np.float32)
>>> psser = ps.from_pandas(pser)
>>> psser / 1
0 1.1
1 2.2
2 3.3
dtype: float32
>>> psser // 1
0 1.0
1 2.0
2 3.0
dtype: float32
```
### How was this patch tested?
Unit tests.
Commands below all passed
```
1103 SPARK_ANSI_SQL_MODE=true ./python/run-tests --python-executables=python3.11 --testnames "pyspark.pandas.tests.computation.test_binary_ops FrameBinaryOpsTests.test_binary_operator_truediv"
1104 SPARK_ANSI_SQL_MODE=false ./python/run-tests --python-executables=python3.11 --testnames "pyspark.pandas.tests.computation.test_binary_ops FrameBinaryOpsTests.test_binary_operator_truediv"
1106 SPARK_ANSI_SQL_MODE=true ./python/run-tests --python-executables=python3.11 --testnames "pyspark.pandas.tests.computation.test_binary_ops FrameBinaryOpsTests.test_binary_operator_floordiv"
1108 SPARK_ANSI_SQL_MODE=false ./python/run-tests --python-executables=python3.11 --testnames "pyspark.pandas.tests.computation.test_binary_ops FrameBinaryOpsTests.test_binary_operator_floordiv"
1126 git status
1127 SPARK_ANSI_SQL_MODE=true ./python/run-tests --python-executables=python3.11 --testnames "pyspark.pandas.tests.computation.test_binary_ops FrameBinaryOpsTests.test_divide_by_zero_behavior"
1128 SPARK_ANSI_SQL_MODE=false ./python/run-tests --python-executables=python3.11 --testnames "pyspark.pandas.tests.computation.test_binary_ops FrameBinaryOpsTests.test_divide_by_zero_behavior"
```
### Was this patch authored or co-authored using generative AI tooling?
No.
Closes apache#51456 from xinrong-meng/div.
Authored-by: Xinrong Meng <xinrong@apache.org>
Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fix float32 type widening in
truediv/floordivwhen ANSI on/off.Why are the changes needed?
Ensure pandas on Spark works well with ANSI mode on/off.
Note that the issue exists whether ANSI mode is on or off, as shown below,
Does this PR introduce any user-facing change?
Yes. truediv/floordiv under ANSI works as expected, with ANSI on/off, as shown below.
How was this patch tested?
Unit tests.
Commands below all passed
Was this patch authored or co-authored using generative AI tooling?
No.