Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-40566: [C++] Fix 3.12 Python support #40322

Merged
merged 1 commit into from Mar 15, 2024

Conversation

SuperSandro2000
Copy link
Contributor

@SuperSandro2000 SuperSandro2000 commented Mar 2, 2024

sysconfig is available since Python 3.2

Tested on nixpkgs and works as expected

Rationale for this change

Support Python 3.12

What changes are included in this PR?

Are these changes tested?

Yes

Are there any user-facing changes?

No

Copy link

github-actions bot commented Mar 2, 2024

Thanks for opening a pull request!

If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose

Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project.

Then could you also rename the pull request title in the following format?

GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

or

MINOR: [${COMPONENT}] ${SUMMARY}

In the case of PARQUET issues on JIRA the title also supports:

PARQUET-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

See also:

sysconfig is available since Python 3.2

Tested on nixpkgs and works as expected
@kou
Copy link
Member

kou commented Mar 3, 2024

Could you open an issue for this?
See also the auto generated comment: #40322 (comment)

@SuperSandro2000 SuperSandro2000 changed the title Fix Python 3.12 support MINOR: [Python ] Fix 3.12 Python support Mar 5, 2024
@SuperSandro2000 SuperSandro2000 changed the title MINOR: [Python ] Fix 3.12 Python support MINOR: [Python] Fix 3.12 Python support Mar 5, 2024
@SuperSandro2000 SuperSandro2000 changed the title MINOR: [Python] Fix 3.12 Python support MINOR: [C++] Fix 3.12 Python support Mar 5, 2024
@SuperSandro2000
Copy link
Contributor Author

I currently lack the time and motivation to open an issue for this benial change and then I would rather close this PR and carry the one line patch for the time being.

@assignUser assignUser changed the title MINOR: [C++] Fix 3.12 Python support GH-40566: [C++] Fix 3.12 Python support Mar 15, 2024
Copy link

⚠️ GitHub issue #40566 has been automatically assigned in GitHub to PR creator.

Copy link
Member

@assignUser assignUser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@SuperSandro2000 could you comment on #40566 so I can assign you? (you can also comment 'take' and the bot will do it)

@github-actions github-actions bot added awaiting committer review Awaiting committer review and removed awaiting review Awaiting review labels Mar 15, 2024
@assignUser assignUser merged commit d3d96a1 into apache:main Mar 15, 2024
34 of 38 checks passed
@assignUser assignUser removed the awaiting committer review Awaiting committer review label Mar 15, 2024
@github-actions github-actions bot added the awaiting review Awaiting review label Mar 15, 2024
@SuperSandro2000 SuperSandro2000 deleted the patch-1 branch March 15, 2024 10:54
Copy link

After merging your PR, Conbench analyzed the 7 benchmarking runs that have been run so far on merge-commit d3d96a1.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants