New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-40566: [C++] Fix 3.12 Python support #40322
Conversation
Thanks for opening a pull request! If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project. Then could you also rename the pull request title in the following format?
or
In the case of PARQUET issues on JIRA the title also supports:
See also: |
sysconfig is available since Python 3.2 Tested on nixpkgs and works as expected
Could you open an issue for this? |
I currently lack the time and motivation to open an issue for this benial change and then I would rather close this PR and carry the one line patch for the time being. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix!
@SuperSandro2000 could you comment on #40566 so I can assign you? (you can also comment 'take' and the bot will do it)
After merging your PR, Conbench analyzed the 7 benchmarking runs that have been run so far on merge-commit d3d96a1. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them. |
sysconfig is available since Python 3.2
Tested on nixpkgs and works as expected
Rationale for this change
Support Python 3.12
What changes are included in this PR?
Are these changes tested?
Yes
Are there any user-facing changes?
No