Template handler name

[mkrizek]

SUMMARY

Fixes #15505
Fixes #17922
Fixes #19898

ISSUE TYPE

• Bugfix Pull Request

COMPONENT NAME

handlers

ANSIBLE VERSION

devel

ADDITIONAL INFORMATION

[bcoca]

won't notifying fail since the handler name used does not exist until you run handlers?

or is this only meant to work with listen:?

[mkrizek]

I think they are notified by their uuid, so notifying shouldn't fail, no? Anyway, the following works:

- hosts: localhost
  gather_facts: no
  vars:
    hname: handler1
  tasks:
    - name: "task to notify {{ hname }}"
      debug:
        msg: "notifying {{ hname }}"
      changed_when: true
      notify: "{{ hname }}"

  handlers:
    - name: "{{ hname }}"
      debug:
        msg: "{{ hname }} called"

There might be a case where it fails I am not aware of.

[bcoca]

No, it gets looked up by either name or listen keywords, THEN it is stored by uuid.

The thing is that the current code change is templating at runtime, this is too late, something else is probably already templating at definition time and this change will only affect display.

Tested your example in devel and it 'works' it just doesn't display the templated name.
< RUNNING HANDLER [{{ hname }}] >

In either case, the variable scope matters, host specific vars for example, won't work.

So this change seems fine, its only display purposes, not 'matching' nor 'definition', though i would look to see if you can get the already templated name (needed to trigger handler) vs having to 're template it'

[mkrizek]

The already templated name does not seem to be stored, it's templated on the lookup [1] and matched with result['_ansible_notify'] (= task.notify which is already templated in TaskExecutor on post_validate). So unsure if I can get it (without making this change bigger and more risky).

https://github.com/ansible/ansible/blob/devel/lib/ansible/plugins/strategy/__init__.py#L369