Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes 17922 - variables not displaying correctly in handler name #18155

Closed
wants to merge 1 commit into from
Closed

Fixes 17922 - variables not displaying correctly in handler name #18155

wants to merge 1 commit into from

Conversation

georgebuckerfield
Copy link

@georgebuckerfield georgebuckerfield commented Oct 23, 2016 •
edited

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

strategy plugin

ANSIBLE VERSION
ansible 2.3.0 (fixes-17922 00a67c5b55) last updated 2016/10/23 22:30:20 (GMT +000)
  lib/ansible/modules/core: (detached HEAD ce44f0a0ae) last updated 2016/10/23 20:06:44 (GMT +000)
  lib/ansible/modules/extras: (detached HEAD 89a8c18c6a) last updated 2016/10/23 20:06:44 (GMT +000)
  config file = 
  configured module search path = Default w/o overrides
SUMMARY

Fixes 17922 (handler names don't display variables names properly).

Handler name shows the raw variable:

RUNNING HANDLER [restart {{ appname }}] ****************************************
changed: [localhost]

Variable now shows correctly:

RUNNING HANDLER [restart foo] **************************************************
changed: [localhost]

@ansibot ansibot added affects_2.3 This issue/PR affects Ansible v2.3 bugfix_pullrequest labels Dec 13, 2016
@ansibot ansibot added needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Dec 16, 2016
@ansibot ansibot added needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jan 2, 2017
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Apr 11, 2017
@calfonso
Copy link
Contributor

@georgebuckerfield This may already be fixed, if you could rebase and let us know, thanks!

@ansibot ansibot added the support:core This issue/PR relates to code supported by the Ansible Engineering Team. label Jun 29, 2017
@ansibot ansibot added the new_contributor This PR is the first contribution by a new community member. label Oct 18, 2017
@ansibot ansibot removed the new_contributor This PR is the first contribution by a new community member. label Nov 3, 2017
@ansibot ansibot added the new_contributor This PR is the first contribution by a new community member. label Jan 22, 2018
@ansibot ansibot added bug This issue/PR relates to a bug. and removed bugfix_pull_request labels Mar 2, 2018
@Akasurde
Copy link
Member

Superseded by #41837

@Akasurde Akasurde closed this Jun 25, 2018
@Akasurde
Copy link
Member

@georgebuckerfield Thanks for the contribution.

@ansible ansible locked and limited conversation to collaborators Jun 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.3 This issue/PR affects Ansible v2.3 bug This issue/PR relates to a bug. c:plugins/strategy needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. new_contributor This PR is the first contribution by a new community member. plugins/strategy stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ansible 2.3.0 (devel) and several earlier versions do not populate variables in handler names.
5 participants
@georgebuckerfield @calfonso @Akasurde @bcoca @ansibot