New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extension crashes on VSCode 1.31.0 #312
Comments
I encounter this problem too |
I have the same problem :( |
Same issue here. I have decided to use an older stable version for now. You might want to turn off automatic updates as well. |
@Bbaale15 when you say "older stable version" are you referring to this extension or VSCode? thanks |
@randallmeeker I am referring to VSCode. |
Same issue after 1.31 upgrade. |
Vscode version 1.31.1 has the same issue as 1.31.0 |
Tested 1.31.1 on 2 projects: 1 in Angular 6 and 1 in angular 5, in Angular 6 no issues, the crash happens on Angular 5 projects. |
@Nemesis19 That is not true, I'm having same issue in Angular 6 version:
|
I have a colleague working on angular 6 and 7 projects. No issue at all. I'm on MacOS 10.13.6, node 11.9 |
Same here |
same here |
if i delete node_modules folder - bug is gone , and service work like it should |
@otecMuxah tried that, doesn't work unfortunately on Angular 5 projects, maybe on other versions? |
Downgrading to 1.30.2 was the only thing that worked for me on Angular 6 |
I believe we should move to this extension #298 (comment) |
possible workaround: From what I can tell the vscode extension is built to use 7.1.x but actually uses the whatever version is found in your project. I see the crash for our angular 5 projects created with nx (using LS 5.2.7). Running I haven't run enough to know if there will be other problems, but it looks promising. |
@v1per Looks good but it's not suitable for everyone, keep in mind that it only supports inline templates at this time. |
i am having same issue with |
Same issue here as well Version: 1.31.1 (system setup) |
see: angular/angular#21420 From what I can tell the fix wouldn't be in any version before 6.0.8. I tested by installing latest 6.1.x and it worked for me. |
Updated language service package as said by @melgish and it works for me too! |
running this worked for me as well: |
thanks @melgish |
I'm on @angular/language-service 7.2.8 and it and it still is silly slow. |
We used @angular/language-service": "6.0.6", 6.0.8 CLI and typescript 2.7.2. After vscode 1.31 released, this problem appears. Same issue with 1.32.3. Based on this topic, downgrading to vscode 1.30 version was a temp solution. But freezing the version of the developer tool seems not fine in a long term future. Via melgish's comment, we changed to the language-service 6.1.10 and CLI 6.2.9 (typescript did not changed), we deleted node_modules and made a new npm install, then we updated vscode version to 1.32.3. This resulted a working dev environment, and the product still worked fine. If major angular version change is not possible in the given project, this minor version change can help. Just for "fun", we upgraded to anguage-service 7.2.8, to 7.3.5 CLI and to 3.1.6 typecsript. After this, dev environment remains fine, but we had to made some code correction beacuse of the mayor angular version change. After these fixes, product still seems ok. |
This worked for me! thanks |
Closing this, since the issue has been fixed. Please reopen otherwise. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
As of VSCode 1.31.0 (January 2019) the extension crashes on use.
The error:
The text was updated successfully, but these errors were encountered: