Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension crashes on VSCode 1.31.0 #312

Closed
JacobMillward opened this issue Feb 7, 2019 · 29 comments
Closed

Extension crashes on VSCode 1.31.0 #312

JacobMillward opened this issue Feb 7, 2019 · 29 comments

Comments

@JacobMillward
Copy link

As of VSCode 1.31.0 (January 2019) the extension crashes on use.

The error:

internal/process/next_tick.js:63
          Reflect.apply(callback, undefined, tock.args);
                  ^

TypeError: Reflect.apply is not a function
    at process._tickCallback (internal/process/next_tick.js:63:19)
@Nemesis19
Copy link

I encounter this problem too

@andrews-phoenix
Copy link

I have the same problem :(

@Bbaale15
Copy link

Same issue here. I have decided to use an older stable version for now. You might want to turn off automatic updates as well.

@randallmeeker
Copy link

@Bbaale15 when you say "older stable version" are you referring to this extension or VSCode? thanks

@Bbaale15
Copy link

@randallmeeker I am referring to VSCode.

@briansg
Copy link

briansg commented Feb 13, 2019

Same issue after 1.31 upgrade.

@Nemesis19
Copy link

Vscode version 1.31.1 has the same issue as 1.31.0

@Nemesis19
Copy link

Tested 1.31.1 on 2 projects: 1 in Angular 6 and 1 in angular 5, in Angular 6 no issues, the crash happens on Angular 5 projects.
Can anyone report if it's the same situation?
Thanks

@blopez2010
Copy link

@Nemesis19 That is not true, I'm having same issue in Angular 6 version:

Angular CLI: 6.0.7
Node: 9.10.1
OS: darwin x64
Angular: 6.0.3

@Nemesis19
Copy link

I have a colleague working on angular 6 and 7 projects. No issue at all.
I tried to disable one by one the extensions, the crashes happen even if Angular language service is the lone installed.

I'm on MacOS 10.13.6, node 11.9

@OmniAndy
Copy link

Same here

@scorbin
Copy link

scorbin commented Feb 19, 2019

same here
mac 10.13.6 node 11.9
@angular/cdk: 5.2.5
@angular/cli: 1.6.4

@otecMuxah
Copy link

otecMuxah commented Feb 20, 2019

if i delete node_modules folder - bug is gone , and service work like it should

@Nemesis19
Copy link

@otecMuxah tried that, doesn't work unfortunately on Angular 5 projects, maybe on other versions?

@alecgorge
Copy link

Downgrading to 1.30.2 was the only thing that worked for me on Angular 6

@v1per
Copy link

v1per commented Feb 20, 2019

I believe we should move to this extension #298 (comment)

@melgish
Copy link

melgish commented Feb 21, 2019

possible workaround:

From what I can tell the vscode extension is built to use 7.1.x but actually uses the whatever version is found in your project.

I see the crash for our angular 5 projects created with nx (using LS 5.2.7). Running npm install @angular/language-service@7.1.x in that project stops it from crashing, and seems to work correctly.

I haven't run enough to know if there will be other problems, but it looks promising.

@briansg
Copy link

briansg commented Feb 21, 2019

I believe we should move to this extension #298 (comment)

@v1per Looks good but it's not suitable for everyone, keep in mind that it only supports inline templates at this time.

@jagdishjadeja
Copy link

i am having same issue with
macos mojave - 10.14.1
vscode 1.31.1 (1.31.1) - 1b8e8302e405050205e69b59abb3559592bb9e60

@gethari
Copy link

gethari commented Feb 22, 2019

Same issue here as well

Version: 1.31.1 (system setup)
Commit: 1b8e8302e405050205e69b59abb3559592bb9e60
Date: 2019-02-12T02:20:54.427Z
Electron: 3.1.2
Chrome: 66.0.3359.181
Node.js: 10.2.0
V8: 6.6.346.32
OS: Windows_NT x64 10.0.17763

@melgish
Copy link

melgish commented Feb 22, 2019

see: angular/angular#21420 From what I can tell the fix wouldn't be in any version before 6.0.8. I tested by installing latest 6.1.x and it worked for me.

@Nemesis19
Copy link

Updated language service package as said by @melgish and it works for me too!

@OmniAndy
Copy link

running this worked for me as well:
npm install @angular/language-service@7.1.x

@tonysamperi
Copy link

thanks @melgish

@nhustak
Copy link

nhustak commented Mar 7, 2019

I'm on @angular/language-service 7.2.8 and it and it still is silly slow.

@csongebalazs
Copy link

We used @angular/language-service": "6.0.6", 6.0.8 CLI and typescript 2.7.2. After vscode 1.31 released, this problem appears. Same issue with 1.32.3.

Based on this topic, downgrading to vscode 1.30 version was a temp solution. But freezing the version of the developer tool seems not fine in a long term future.

Via melgish's comment, we changed to the language-service 6.1.10 and CLI 6.2.9 (typescript did not changed), we deleted node_modules and made a new npm install, then we updated vscode version to 1.32.3. This resulted a working dev environment, and the product still worked fine. If major angular version change is not possible in the given project, this minor version change can help.

Just for "fun", we upgraded to anguage-service 7.2.8, to 7.3.5 CLI and to 3.1.6 typecsript. After this, dev environment remains fine, but we had to made some code correction beacuse of the mayor angular version change. After these fixes, product still seems ok.

@lest-xu
Copy link

lest-xu commented May 15, 2019

running this worked for me as well:
npm install @angular/language-service@7.1.x

This worked for me! thanks

@kyliau
Copy link
Contributor

kyliau commented Nov 12, 2019

Closing this, since the issue has been fixed. Please reopen otherwise.

@kyliau kyliau closed this as completed Nov 12, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests