Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't work at all #316

Closed
jpike88 opened this issue Feb 26, 2019 · 11 comments
Closed

Doesn't work at all #316

jpike88 opened this issue Feb 26, 2019 · 11 comments

Comments

@jpike88
Copy link

jpike88 commented Feb 26, 2019

This plugin doesn't work. At it does is churn my memory. On VSCode 1.31.1 with TypeScript 3.3.1, macOS Mojave.

Reviews all seem to be saying the same thing for the last 4-5 months. @kyliau is this project abandoned?

@jpike88
Copy link
Author

jpike88 commented Feb 26, 2019

I'm going to use this extension instead

https://marketplace.visualstudio.com/items?itemName=cyrilletuzi.typescript-angular-plugin

@nhustak
Copy link

nhustak commented Feb 26, 2019

This has been going on for a couple of months now and progressively getting worse.

@nhustak
Copy link

nhustak commented Feb 26, 2019

@jpike88 I hope you had better luck than I did with the alternative one. Speed still a huge issue. Starting to suspect the language service is the issue rather than the plugins. Oh and I don't like inline templates 8)

@jpike88
Copy link
Author

jpike88 commented Feb 27, 2019

It's actually alright, but the catch is that it requires you to inline your templates... not such a bad thing actually, I can live with that. Just doesn't have autocomplete. But useful enough to be worth a download

@nhustak
Copy link

nhustak commented Feb 27, 2019

@jpike88 ok no i'm wrong. I managed to disable both of them while screwing around.

Meh, I"m just going to live without the angular language service. I need my regular intellisense. And I"m not switching to inline templates.

THanks!

@dcanning
Copy link

dcanning commented Mar 7, 2019

see issue #312

@AnthonyLenglet
Copy link

Just got this extension to work on one of my project by stumbling on a small stack overflow question

Turns out that my tsconfig.json had a trailing comma that vscode accepted, so it showed no error at all, remving that one comma fixed the whole thing

@timscullin
Copy link

Just got this extension to work on one of my project by stumbling on a small stack overflow question

Turns out that my tsconfig.json had a trailing comma that vscode accepted, so it showed no error at all, remving that one comma fixed the whole thing

This actually worked for me!

@jpike88
Copy link
Author

jpike88 commented May 8, 2019

Didn't work for me though. Maybe your projects are small/simple enough or something. I have three tsconfigs, one of them is a shared project and this extension absolutely craps itself.

https://marketplace.visualstudio.com/items?itemName=cyrilletuzi.typescript-angular-plugin

^ That worked for me flawlessly

@kyliau
Copy link
Contributor

kyliau commented May 28, 2019

Released v0.800.0 that fixed performance regression.
Multiple beta users confirmed that language service works well with Angular v7 and v8.
Please open another issue if this is not the case.
https://github.com/angular/vscode-ng-language-service/releases/tag/v0.800.0

Related issues:

@kyliau kyliau closed this as completed May 28, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants