Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Team signin: Unauthorized although TFS credential is valid #68442

Closed
Yeg-A opened this issue Feb 11, 2019 · 10 comments
Closed

Team signin: Unauthorized although TFS credential is valid #68442

Yeg-A opened this issue Feb 11, 2019 · 10 comments
Labels
*caused-by-extension Issue identified to be caused by an extension

Comments

@Yeg-A
Copy link

Yeg-A commented Feb 11, 2019

Version: 1.31.0 (system setup)
Commit: 7c66f58
Date: 2019-02-05T22:35:56.624Z
Electron: 3.1.2
Chrome: 66.0.3359.181
Node.js: 10.2.0
V8: 6.6.346.32
OS: Windows_NT x64 10.0.14393

[Main Instruction]
Visual Studio Code

[Content]

Although VS code is tracking changes from source control, there is a bug preventing it from connecting to TFS (this happened after upgrading to 1.31.0)

[OK] [Copy]

image

Steps to Reproduce:

  1. Upgrade to 1.31.0
  2. Try signin in to TFS

Does this issue occur when all extensions are disabled?: Yes

@peni4142
Copy link

Same for SharePoint, using node-sp-auth

		spauth
			.getAuth(url, {
				username: UserName,
				password: password,
				domain: UserDomain
			})
			.then(data => {
				let headers: any = data.headers;
				headers.Accept = "application/json;odata=verbose";
				let requestOpts: any = data.options;
				requestOpts.json = true;
				requestOpts.headers = headers;
				requestOpts.url = uri;
				requestOpts.form = postOptions.form;

				request.get(requestOpts).then(response => {
					this.logSuccess(response);
				}).catch(er => {
					console.log(er);
					}
				}).then(() => {
					console.log("end");
				});
			});

@bpasero bpasero added the *caused-by-extension Issue identified to be caused by an extension label Feb 12, 2019
@vscodebot
Copy link

vscodebot bot commented Feb 12, 2019

This issue is caused by an extension, please file it with the repository (or contact) the extension has linked in its overview in VS Code or the marketplace for VS Code. See also our issue reporting guidelines.

Happy Coding!

@vscodebot vscodebot bot closed this as completed Feb 12, 2019
@peni4142
Copy link

peni4142 commented Feb 12, 2019

Reporting a bug to Microsoft is like hell.
-- Not my bug... Report it to xyz. (Mostly another Microsoft repository. Can't you write a bot for something like that?)

Yeah please reopen this. I have exactly the same code running in a VSCode extension and also without VSCode. Without VSCode it is working. Till version 1.30.2 it is working. With Version 1.31.0 it is not working.

In the end, our customer and partners will not update VSCode until it is fixed. And I think that is not in your interest.

And of course, I tried also in NodeJS v10.2.0

@thezuliano
Copy link

Solved!

My version of Code:

image

Steps to fix:

1)- Open VS Code settings (Ctrl + ,)
2)- Search by "Proxy"
3)- Change Http Proxy support from Override to OFF

image

:D

@chrmarti
Copy link
Contributor

This should be fixed in current insiders builds of VS Code with the Proxy Support setting set to 'override'. Let me know if you still see any issues with that. Download: https://code.visualstudio.com/insiders/

@erikread
Copy link

I was experiencing this issue. I followed the instructions (set proxy to off) and downloaded the insiders build. While I can now authenticate, either VS Code or the Azure Repos extensions sees all of my local workspaces as server.

@Yeg-A
Copy link
Author

Yeg-A commented Feb 20, 2019

This should be fixed in current insiders builds of VS Code with the Proxy Support setting set to 'override'. Let me know if you still see any issues with that. Download: https://code.visualstudio.com/insiders/

There is also another bug associated with v 1.31: angular/vscode-ng-language-service#312 (comment)

@erikread
Copy link

erikread commented Feb 20, 2019

I have downloaded the latest insider build. All of my workspaces are local. For a minute or so VS Code acts like everything is fine then it pops up the error.
Extension information:
Name: Azure Repos
Id: ms-vsts.team
Description: Connect to Azure Repos and work with Git and Team Foundation Version Control (TFVC) repositories. Manage your pull requests, work items, and more.
Version: 1.144.1
Publisher: Microsoft
VS Marketplace Link: https://marketplace.visualstudio.com/items?itemName=ms-vsts.team

image
image
image
workspaces.txt
image

@chrmarti
Copy link
Contributor

@erikread That looks like an issue with the extension, could you check if they have an issue open for this and create one if they don't at https://github.com/Microsoft/azure-repos-vscode/issues ?

@erikread
Copy link

Normally I would agree with you but I went back to 1.29.1 (October Release) and all is good. Same version of the extension. So, at the very least, it is a combination of changes in the release and something in the extension. There is an open issue for this problem and have added my information.

@vscodebot vscodebot bot locked and limited conversation to collaborators Mar 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*caused-by-extension Issue identified to be caused by an extension
Projects
None yet
Development

No branches or pull requests

6 participants