Feature request: Get references in template (getReferencesAtPosition) #29

kukjevov · 2016-12-19T14:18:25Z

Hi,

as for now you can navigate to source by ctrl+click, or peek definition, but if you use find all usages template occurencies on methods or properties are not in result window.

This would be awesome, but i`m not sure that this is possible to do in VsCode, but it would be nice :). Especially while refactoring code, since right now this occurencies can be forgotten or must be string searched.

Thank you

simonnagl · 2017-07-21T12:22:09Z

This would also enabling symbols in templates (i.e. using F2)

przemo098 · 2018-05-19T18:32:47Z

Someone is doing something with this?!

EylonSu · 2019-04-29T17:21:08Z

anything new?

ayazhafiz · 2019-09-20T02:55:03Z

We should be able to implement this by adding getReferencesAtPosition to the Language Service's TypeScript plugin. However, we will probably hold off on doing this until the language service is rewritten to use Angular's new Ivy compiler, which will make it easier to extract the class properties used in a template.

_{(note: perhaps we can use the Angular indexing API or similar for this)}

abdulkareemnalband · 2020-03-02T07:49:58Z

@kukjevov @kyliau Can you update title and content of this issue
many people are creating duplicates as this is not visible in search

Suggestion: Find property references in template from typescript

kukjevov · 2020-03-13T05:51:06Z

It had different name Feature request: Find usages shows also occurencies in templates as you can see but it was changed by @kyliau

So you have to make agreement with him :).

Niaro · 2020-06-03T09:22:24Z

4 years?) I wonder how WebStorm got this faster than VScode O_o

furmandev · 2020-06-03T18:05:27Z

This would be a great feature. Is there any timeline or priority on this? I think this issue also relates to #252

Keen and I were talking about what it would take to support getting references at a position in the current language service, since it's unclear when more investment in the Ivy LS will be available. Getting TS references from a template is trivial -- we simply need to get the definition of a symbol, which is already handled by the language service, and ask the TS language service to give us the references for that definition. This doesn't handle references in templates, but that could be done in a subsequent pass. Part of angular/vscode-ng-language-service#29

kyliau · 2020-06-04T18:33:22Z

We hear you! @ayazhafiz and I are thinking about ways to support this in Angular language service. @ayazhafiz already has a PR ready that partially* supports this feature.
We're currently looking into the best way to introduce get references without adding too much overhead, since much of this code will not be reused once we switch the backend to Ivy.

Re partial support:
References from template can be easily retrieved, whereas references from TS (for example a field in a class) is more difficult because we need to check the template. The former is what Ayaz's PR is for.

Keen and I were talking about what it would take to support getting references at a position in the current language service, since it's unclear when more investment in the Ivy LS will be available. Getting TS references from a template is trivial -- we simply need to get the definition of a symbol, which is already handled by the language service, and ask the TS language service to give us the references for that definition. This doesn't handle references in templates, but that could be done in a subsequent pass. Part of angular/vscode-ng-language-service#29

Keen and I were talking about what it would take to support getting references at a position in the current language service, since it's unclear when more investment in the Ivy LS will be available. Getting TS references from a template is trivial -- we simply need to get the definition of a symbol, which is already handled by the language service, and ask the TS language service to give us the references for that definition. This doesn't handle references in templates, but that could be done in a subsequent pass. Part of angular/vscode-ng-language-service#29 PR Close #37437

) Keen and I were talking about what it would take to support getting references at a position in the current language service, since it's unclear when more investment in the Ivy LS will be available. Getting TS references from a template is trivial -- we simply need to get the definition of a symbol, which is already handled by the language service, and ask the TS language service to give us the references for that definition. This doesn't handle references in templates, but that could be done in a subsequent pass. Part of angular/vscode-ng-language-service#29 PR Close angular#37437

webia1 · 2020-07-02T10:26:39Z

I would be very thankful for every process.

Harpush · 2020-08-04T05:01:13Z

Any news on this? Seems the PR wasn't merged

) Keen and I were talking about what it would take to support getting references at a position in the current language service, since it's unclear when more investment in the Ivy LS will be available. Getting TS references from a template is trivial -- we simply need to get the definition of a symbol, which is already handled by the language service, and ask the TS language service to give us the references for that definition. This doesn't handle references in templates, but that could be done in a subsequent pass. Part of angular/vscode-ng-language-service#29 PR Close angular#37437

AxiomeCG · 2020-10-05T07:52:22Z

Really excited about this feature, is there any news about it ?
Very painful to track down broken reference in the template while renaming the symbol in the typescript file.

kyliau · 2020-10-05T22:55:52Z

We are going to launch Ivy version of the language service in version 11 (November 2020). Once it's achieve feature parity with the existing View Engine language service, we'll prioritize this feature! Switching to the Ivy backend enables us to implement features like this one, which was almost impossible previously.

atscott · 2021-01-22T18:18:08Z

This has been fixed by the new Ivy-native language service, released in v11.1.0.
It's an opt-in feature for now, please give it a try and let us know if you have any feedback.
For the best editor experience, please make sure your project has strictTemplates enabled in angularCompilerOptions.
In case you run into similar bug, please file a new issue. I'll close this for now.

ic3guy · 2021-01-30T00:55:29Z

Should we be seeing the correct # of references via CodeLens too? Because Ctrl-Click / Find all References does work, but codelens references and a click on it does not show template refs. I'm assuming that CodeLens pulls these refs from somewhere else, or am I missing a config flag somewhere?

atscott · 2021-02-01T18:12:50Z

Should we be seeing the correct # of references via CodeLens too?

Great question! It looks like there's additional configuration needed on our end for integrating with CodeLens. Could you open a new issue for this?

Edit: Re-opening #162

kukjevov · 2021-02-15T19:26:55Z

@atscott @ic3guy Guys am I missing something, or is there something weird with configuration of project :)? Because i tried it in my own project and it does not work, I even tried latest version of Angular cli, generated new project, there is title property, but if i use find all references, reference from template is not displayed? Am I missing something :D ?

Thx

kukjevov · 2021-02-16T10:59:31Z

@atscott hmmm i have looked at it and i found out, that it needs to be turned on, but if i turn it on, it keeps crashing and restarting, should i open new issue or paste it here :) ?

atscott · 2021-02-16T16:12:50Z

@atscott hmmm i have looked at it and i found out, that it needs to be turned on, but if i turn it on, it keeps crashing and restarting, should i open new issue or paste it here :) ?

@kukjevov yes, please submit a new issue for this.

erosostolato · 2021-03-01T13:38:57Z

Hey guys, I couldn't get it to work. What do I need to do? Do I need to enable any option?

kukjevov · 2021-03-01T13:45:12Z

@erosostolato if you have installed language server and vscode extensions for angular then in user preferences you can find Angular: Experimental-ivy, if you enable it it should start working, in my case it is crashing, i need to create new issue for it

erosostolato · 2021-03-01T14:44:54Z

@kukjevov

The only thing that I can do is renaming a template variable like this:

But if I try to rename it directly in the interface, it doesn't work... it doesn't even show the reference count

This is my settings page:

kukjevov · 2021-03-01T14:47:35Z

If i saw it correctly, what should be working so far is only getting correct number of references in templates :), renaming is feature that i saw in Angular 12 beta.0 so it is not working, because it is still not there :), but it should be soon :).

kukjevov · 2021-03-01T14:49:15Z

Codelens also needs some work, so only find all references should be working, but still there is some problem in my project because if i turn it on, it crashes :).

atscott · 2021-03-01T14:53:21Z

FYI - renaming for Angular is only available in external templates. There is now way to ensure that the Angular extension is used in TypeScript files so we opted to disable it there. See microsoft/vscode#115354. If you would like this feature, it could be worth upvoting the vscode issue so it gets prioritized sooner.

erosostolato · 2021-03-01T14:55:46Z

@kukjevov you're right, I saw it working for find all references.

@atscott got it! I already upvoted

atscott · 2021-03-01T14:56:06Z

Codelens also needs some work, so only find all references should be working.

In reference to Codelens, there is no way to augment those results with ours. We can consider providing our own, separate lens in addition to the typescript one that could say something like “# references in templates” but we can’t include our results in the same one that’s already there.

erosostolato · 2021-03-01T15:03:24Z

Codelens also needs some work, so only find all references should be working.

In reference to Codelens, there is no way to augment those results with ours. We can consider providing our own, separate lens in addition to the typescript one that could say something like “# references in templates” but we can’t include our results in the same one that’s already there.

@atscott I liked the idea of having “# references in templates”. That could work as a notice for the developer that wants to rename a variable, so he can go to the template and rename it from there.

angular-automatic-lock-bot · 2021-04-01T16:02:16Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

chuckjaz added the feature label Dec 19, 2016

kisstkondoros mentioned this issue Jun 29, 2017

Integrate with Angular Language Service kisstkondoros/typelens#22

Closed

kukjevov mentioned this issue Jul 21, 2017

Rename Symbols in Templates. #133

Closed

ayazhafiz added the ivy Feature / enhancement / bug fix in Ivy label Sep 20, 2019

This was referenced Nov 9, 2019

Feature Request - Add Support for "Find All References" right mouse click #259

Closed

References CodeLens for templates #162

Open

kyliau changed the title ~~Feature request: Find usages shows also occurencies in templates~~ Feature request: getReferencesAtPosition Nov 11, 2019

kyliau mentioned this issue Jan 13, 2020

feat Angular Language Service TS to HTML awareness angular/angular#26858

Closed

ayazhafiz mentioned this issue Feb 4, 2020

reference to function/variables being refferred in HTML #612

Closed

ayazhafiz added the lib Relates to an issue in the @angular/language-service library label Feb 21, 2020

ayazhafiz changed the title ~~Feature request: getReferencesAtPosition~~ Feature request: Get references in template (getReferencesAtPosition) Mar 14, 2020

ayazhafiz mentioned this issue Jun 4, 2020

feat(language-service): TS references from template items angular/angular#37437

Closed

6 tasks

This was referenced Jun 9, 2020

"Get References" in the Angular LS angular/angular#37496

Closed

Rename selector #816

Open

ayazhafiz mentioned this issue Jun 25, 2020

Renaming template reference variables #829

Closed

kyliau mentioned this issue Nov 24, 2020

Add "find references" capability to Ivy integrated Language Service angular/angular#39768

Closed

kyliau assigned atscott Nov 24, 2020

jerone mentioned this issue Dec 14, 2020

[Feature Request] Take Angular/React/VUE template event binding reference as reference count. kisstkondoros/typelens#56

Closed

atscott closed this as completed Jan 22, 2021

angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 1, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature request: Get references in template (getReferencesAtPosition) #29

Feature request: Get references in template (getReferencesAtPosition) #29

kukjevov commented Dec 19, 2016

simonnagl commented Jul 21, 2017

przemo098 commented May 19, 2018

EylonSu commented Apr 29, 2019

ayazhafiz commented Sep 20, 2019

abdulkareemnalband commented Mar 2, 2020

kukjevov commented Mar 13, 2020

Niaro commented Jun 3, 2020

furmandev commented Jun 3, 2020

kyliau commented Jun 4, 2020

webia1 commented Jul 2, 2020

Harpush commented Aug 4, 2020

AxiomeCG commented Oct 5, 2020

kyliau commented Oct 5, 2020

atscott commented Jan 22, 2021

ic3guy commented Jan 30, 2021

atscott commented Feb 1, 2021 •

edited

kukjevov commented Feb 15, 2021

kukjevov commented Feb 16, 2021 •

edited

atscott commented Feb 16, 2021

erosostolato commented Mar 1, 2021

kukjevov commented Mar 1, 2021

erosostolato commented Mar 1, 2021 •

edited

kukjevov commented Mar 1, 2021

kukjevov commented Mar 1, 2021

atscott commented Mar 1, 2021

erosostolato commented Mar 1, 2021

atscott commented Mar 1, 2021

erosostolato commented Mar 1, 2021 •

edited

angular-automatic-lock-bot bot commented Apr 1, 2021

Feature request: Get references in template (getReferencesAtPosition) #29

Feature request: Get references in template (getReferencesAtPosition) #29

Comments

kukjevov commented Dec 19, 2016

simonnagl commented Jul 21, 2017

przemo098 commented May 19, 2018

EylonSu commented Apr 29, 2019

ayazhafiz commented Sep 20, 2019

abdulkareemnalband commented Mar 2, 2020

kukjevov commented Mar 13, 2020

Niaro commented Jun 3, 2020

furmandev commented Jun 3, 2020

kyliau commented Jun 4, 2020

webia1 commented Jul 2, 2020

Harpush commented Aug 4, 2020

AxiomeCG commented Oct 5, 2020

kyliau commented Oct 5, 2020

atscott commented Jan 22, 2021

ic3guy commented Jan 30, 2021

atscott commented Feb 1, 2021 • edited

kukjevov commented Feb 15, 2021

kukjevov commented Feb 16, 2021 • edited

atscott commented Feb 16, 2021

erosostolato commented Mar 1, 2021

kukjevov commented Mar 1, 2021

erosostolato commented Mar 1, 2021 • edited

kukjevov commented Mar 1, 2021

kukjevov commented Mar 1, 2021

atscott commented Mar 1, 2021

erosostolato commented Mar 1, 2021

atscott commented Mar 1, 2021

erosostolato commented Mar 1, 2021 • edited

angular-automatic-lock-bot bot commented Apr 1, 2021

atscott commented Feb 1, 2021 •

edited

kukjevov commented Feb 16, 2021 •

edited

erosostolato commented Mar 1, 2021 •

edited

erosostolato commented Mar 1, 2021 •

edited