Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat Angular Language Service TS to HTML awareness #26858

Closed
william-lohan opened this issue Oct 30, 2018 · 5 comments
Closed

feat Angular Language Service TS to HTML awareness #26858

william-lohan opened this issue Oct 30, 2018 · 5 comments
Assignees
Labels
area: language-service Issues related to Angular's VS Code language service

Comments

@william-lohan
Copy link

william-lohan commented Oct 30, 2018

I'm submitting a...


[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report  
[ ] Performance issue
[X] Feature request
[ ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead see https://github.com/angular/angular/blob/master/CONTRIBUTING.md#question
[ ] Other... Please describe:

Current behavior

my.component.html

<button (click)="onButtonClick()">My Button</button>

my.component.ts (vs code with typescript.referencesCodeLens.enabled)


    0 references
    public onButtonClick() {}

or right-click Find All Refrences (Shift + F12) doesn't show html template

Expected behavior

my.component.ts (vs code with typescript.referencesCodeLens.enabled)


    1 reference
    public onButtonClick() {}

or right-click Find All Refrences (Shift + F12) does show html template

@abhiad
Copy link

abhiad commented Oct 30, 2018 via email

@matsko matsko added the area: language-service Issues related to Angular's VS Code language service label Oct 30, 2018
@ngbot ngbot bot added this to the needsTriage milestone Oct 30, 2018
@lemoinem
Copy link
Contributor

@abhiad You must have watched the repository on Github. If you watch a repository, you will be sent an email for each new issue and/or PR.
The best would probably be to unwatch the repository and only subscribe to individual issues that interest you.
Go to GitHub, repository angular/angular, then at the top, next to the repo's name, you'll have three buttons "Unwatch", "Star", "Fork".
Click on "Unwatch" and then on "Not Watching".

Maybe reviewing your Github preferences to make sure you do not start watching automatically stuff that you don't want to could help as well.

@kyliau kyliau modified the milestones: needsTriage, Ivy Dec 5, 2018
@kyliau
Copy link
Contributor

kyliau commented Dec 5, 2018

This is will be addressed as part of the language service upgrade after Ivy is released

@kyliau kyliau self-assigned this May 23, 2019
@kyliau
Copy link
Contributor

kyliau commented Jan 13, 2020

Tracking this work in angular/vscode-ng-language-service#29

@kyliau kyliau closed this as completed Jan 13, 2020
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: language-service Issues related to Angular's VS Code language service
Projects
None yet
Development

No branches or pull requests

5 participants