feat(language-service): TS references from template items #37437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyliau
suggested changes
Jun 4, 2020
There was a problem hiding this comment.
Did you mean to not expose this for now?
We'll need to make getReferencesAtPosition part of the plugin for it to be externally available.
angular/packages/language-service/src/ts_plugin.ts
Lines 90 to 101 in c8f7fc2
devversion
approved these changes
Jun 4, 2020
I think it's okay to expose it in this package, it doesn't need to be known by the VSCode extension until it's in a more useful state IMO. |
Keen and I were talking about what it would take to support getting references at a position in the current language service, since it's unclear when more investment in the Ivy LS will be available. Getting TS references from a template is trivial -- we simply need to get the definition of a symbol, which is already handled by the language service, and ask the TS language service to give us the references for that definition. This doesn't handle references in templates, but that could be done in a subsequent pass. Part of angular/vscode-ng-language-service#29
ayazhafiz
force-pushed
the
e/references-in-ts
branch
from
c2e7c3e
to
335ea03
Compare
kyliau
approved these changes
Jun 8, 2020
| }); | ||
| }); | ||
|
|
||
| // TODO: override parsing-cases#TemplateReference for inline templates. |
There was a problem hiding this comment.
This'd be nice, TemplateReference already has an external template though..
There was a problem hiding this comment.
yeah but we can just overwrite and replace templateUrl
kyliau
added
area: language-service
kyliau
approved these changes
Jun 8, 2020
kyliau
removed
the
action: cleanup
atscott
pushed a commit
that referenced
this pull request
Jun 9, 2020
Keen and I were talking about what it would take to support getting references at a position in the current language service, since it's unclear when more investment in the Ivy LS will be available. Getting TS references from a template is trivial -- we simply need to get the definition of a symbol, which is already handled by the language service, and ask the TS language service to give us the references for that definition. This doesn't handle references in templates, but that could be done in a subsequent pass. Part of angular/vscode-ng-language-service#29 PR Close #37437
ngwattcos
pushed a commit
to ngwattcos/angular
that referenced
this pull request
Jun 25, 2020
) Keen and I were talking about what it would take to support getting references at a position in the current language service, since it's unclear when more investment in the Ivy LS will be available. Getting TS references from a template is trivial -- we simply need to get the definition of a symbol, which is already handled by the language service, and ask the TS language service to give us the references for that definition. This doesn't handle references in templates, but that could be done in a subsequent pass. Part of angular/vscode-ng-language-service#29 PR Close angular#37437
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
profanis
pushed a commit
to profanis/angular
that referenced
this pull request
Sep 5, 2020
) Keen and I were talking about what it would take to support getting references at a position in the current language service, since it's unclear when more investment in the Ivy LS will be available. Getting TS references from a template is trivial -- we simply need to get the definition of a symbol, which is already handled by the language service, and ask the TS language service to give us the references for that definition. This doesn't handle references in templates, but that could be done in a subsequent pass. Part of angular/vscode-ng-language-service#29 PR Close angular#37437
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keen and I were talking about what it would take to support getting
references at a position in the current language service, since it's
unclear when more investment in the Ivy LS will be available. Getting TS
references from a template is trivial -- we simply need to get the
definition of a symbol, which is already handled by the language
service, and ask the TS language service to give us the references for
that definition.
This doesn't handle references in templates, but that could be done in a
subsequent pass.
Part of angular/vscode-ng-language-service#29
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Does this PR introduce a breaking change?