Skip to content
This repository was archived by the owner on Jul 29, 2024. It is now read-only.

Conversation

@anibalsanchez
Copy link
Contributor

A tweak to the documentation to add the Locator by.name.

Amazing tool!
Anibal

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot. The email used to register you as an authorized contributor must be the email used for the Git commit.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

1 similar comment
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot. The email used to register you as an authorized contributor must be the email used for the Git commit.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

@anibalsanchez
Copy link
Contributor Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

1 similar comment
@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes and removed cla: no labels Jan 8, 2018
@qiyigg
Copy link
Contributor

qiyigg commented Jan 8, 2018

@anibalsanchez Would you mind updating the comment according to https://github.com/angular/protractor/blob/master/CONTRIBUTING.md

Thanks a lot!

@anibalsanchez
Copy link
Contributor Author

This is an improvement to the site documentation. Not a change to protractor itself.

@qiyigg
Copy link
Contributor

qiyigg commented Jan 8, 2018

@anibalsanchez you can just use fix(doc) or fix(website)

@anibalsanchez anibalsanchez changed the title Doc improvement - Locator by.name('field_name') docs(website): Site improvement - Locator by.name('field_name') Jan 8, 2018
@anibalsanchez anibalsanchez changed the title docs(website): Site improvement - Locator by.name('field_name') fix(website): Site improvement - Locator by.name('field_name') Jan 8, 2018
@anibalsanchez
Copy link
Contributor Author

Done. I've just renamed the topic.

@qiyigg
Copy link
Contributor

qiyigg commented Jan 8, 2018

merged. thanks!

@qiyigg qiyigg merged commit 83e2ba8 into angular:master Jan 8, 2018
firstor pushed a commit to firstor/protractor that referenced this pull request Apr 21, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants