Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AXI-AD3552R #2194

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Add AXI-AD3552R #2194

wants to merge 4 commits into from

Conversation

machschmitt
Copy link
Contributor

@machschmitt machschmitt commented May 19, 2023

Add the AXI-AD3585R DAC driver which adapts AD3585R for use with ad3552r_evb HDL project.

Comments:

  • Add AXI-AD3585R platform driver.
  • dt-binding documentation leveraged by upstream version.
  • There is a second HDL project which uses the AXI-AD3585R driver and that one also depends on updated versions of MathWorks drivers from PR drivers:misc:mathworks: Sync MathWorks drivers #2193. I left the changes related to that project to a follow-up PR.

@machschmitt machschmitt changed the title Staging/axi ad3552r Add AXI-AD3552R May 19, 2023
machschmitt and others added 4 commits May 22, 2023 13:32
Add device tree schema binding documentation for AXI-AD3552R.

Signed-off-by: Marcelo Schmitt <marcelo.schmitt@analog.com>
Add devicetree file for the AD3552R evaluation board.

Signed-off-by: PopPaul2021 <paul.pop@analog.com>
Add support for AD3552R device using custom HDL interface IP.

Signed-off-by: PopPaul2021 <paul.pop@analog.com>
Add the AXI_AD3552R DAC for custom HDL interface IP to ADI IIO Kconfig.

Signed-off-by: Marcelo Schmitt <marcelo.schmitt@analog.com>
@machschmitt
Copy link
Contributor Author

Update: removed unused device tree properties from the axi-ad3552r_evb dts file and from the dt-binding doc.

@nunojsa
Copy link
Collaborator

nunojsa commented Jun 7, 2023

Before jumping in reviewing, How is this supposed to work with the real HW DAC? Asking it because typically you have the converter/frontend (in this case a DAC) wich connects to a backend (the hdl IP) and that backend is cf_axi_dds.

At first glance I can see that there are a fairly amount of specific registers for this core but I'm still trying to understand if extending cf_axi_dds.c was considered or if it makes any sense to do so?

I just want to avoid having code duplication all over the place if we start implementing these projects like this (typically we use the above "arrangement").

@machschmitt
Copy link
Contributor Author

At first glance I can see that there are a fairly amount of specific registers for this core but I'm still trying to understand if extending cf_axi_dds.c was considered or if it makes any sense to do so?

Apparently yes, the cf_axi_dds driver could be extended to also support ad3552r. So I'm working on that refactoring/extension now. Meanwhile, let's turn this into a draft.

@machschmitt machschmitt marked this pull request as draft June 12, 2023 14:01
@SRaus SRaus changed the base branch from master to main January 9, 2024 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants