-
Notifications
You must be signed in to change notification settings - Fork 808
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add AXI-AD3552R #2194
base: main
Are you sure you want to change the base?
Add AXI-AD3552R #2194
Conversation
f79235b
to
3958edf
Compare
Add device tree schema binding documentation for AXI-AD3552R. Signed-off-by: Marcelo Schmitt <marcelo.schmitt@analog.com>
Add devicetree file for the AD3552R evaluation board. Signed-off-by: PopPaul2021 <paul.pop@analog.com>
Add support for AD3552R device using custom HDL interface IP. Signed-off-by: PopPaul2021 <paul.pop@analog.com>
Add the AXI_AD3552R DAC for custom HDL interface IP to ADI IIO Kconfig. Signed-off-by: Marcelo Schmitt <marcelo.schmitt@analog.com>
3958edf
to
8657322
Compare
Update: removed unused device tree properties from the axi-ad3552r_evb dts file and from the dt-binding doc. |
Before jumping in reviewing, How is this supposed to work with the real HW DAC? Asking it because typically you have the converter/frontend (in this case a DAC) wich connects to a backend (the hdl IP) and that backend is cf_axi_dds. At first glance I can see that there are a fairly amount of specific registers for this core but I'm still trying to understand if extending cf_axi_dds.c was considered or if it makes any sense to do so? I just want to avoid having code duplication all over the place if we start implementing these projects like this (typically we use the above "arrangement"). |
Apparently yes, the cf_axi_dds driver could be extended to also support ad3552r. So I'm working on that refactoring/extension now. Meanwhile, let's turn this into a draft. |
Add the AXI-AD3585R DAC driver which adapts AD3585R for use with ad3552r_evb HDL project.
Comments: