Use the name provided by musicbrainz rather than the ALBUMARTIST tag #3834
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a potential solution for #3833 . It basically sets the name that musicbrainz provides when creating a new album artist.
I don't find this solution particularly elegant for a couple of things:
check_mbid()
.check_mbid()
function, so maybe it is the time to promote the plugin to be part of the core, since ampache already relies on musicbrainz metadata extensively for its correct behaviour.Maybe this can be merged for the time being to fix the bug, but in the long run it is probably better to refactor the logic when creating a new artist to avoid a cleaner code.
BTW, other possibility to solve #3833 is to "properly" parse the
ALBUMARTIST
tag. However I find that prone to error the general case. If no mbid are available then that's the only option, but if mbid do exist then I think the best option is to rely on a proper musicbrainz query.