Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong artist name in a multiartist album #3833

Open
cquike opened this issue Feb 20, 2024 · 2 comments
Open

Wrong artist name in a multiartist album #3833

cquike opened this issue Feb 20, 2024 · 2 comments

Comments

@cquike
Copy link
Contributor

cquike commented Feb 20, 2024

Description

I have an album which has two artists. I have added metadata with picard which results in the following (among others) tags:

    comment[2]: ARTIST=Johann Christian Bach
    comment[7]: ALBUMARTISTSORT=Concentus Musicus Wien, Harnoncourt, Nikolaus
    comment[13]: ALBUMARTIST=Concentus Musicus Wien, Nikolaus Harnoncourt
    comment[14]: MUSICBRAINZ_TRACKID=36dafc10-1413-4b3a-8d43-8016f65b6d08
    comment[15]: ARTISTS=Johann Christian Bach
    comment[16]: ARTISTSORT=Bach, Johann Christian
    comment[17]: MUSICBRAINZ_ARTISTID=470967b1-f9ef-4712-82df-6971b517ebdb
    comment[18]: MUSICBRAINZ_RELEASEGROUPID=309c0745-655d-3d25-8998-5db1b5611af9
    comment[20]: MUSICBRAINZ_ALBUMID=04991fc4-3e14-47de-81c6-1a48105a17b7
    comment[21]: MUSICBRAINZ_ALBUMARTISTID=9b891046-35af-4eb0-a058-eba4c9b8d01f
    comment[22]: MUSICBRAINZ_ALBUMARTISTID=98b95966-64db-4631-8b9f-8aa66f32cc98
    comment[23]: MUSICBRAINZ_DISCID=grAa4zTRM7Rs6YC5Bd_jhVccOUc-
    comment[24]: MUSICBRAINZ_RELEASETRACKID=8a330fbc-b19e-337d-b620-4d9b3cf53857

As you can see there are two album artists: https://musicbrainz.org/artist/9b891046-35af-4eb0-a058-eba4c9b8d01f and https://musicbrainz.org/artist/98b95966-64db-4631-8b9f-8aa66f32cc98. ampache correctly identifies that there are two artists in the album. However it wrongly sets the name of the first one to the full ALBUMARTIST string, which contains the name of both authors:

mannheim

That can also be seen in the database:

+-------+----------------------------------------------+--------------------------------------+
| id    | name                                         | mbid                                 |
+-------+----------------------------------------------+--------------------------------------+
| 16640 | Concentus Musicus Wien, Nikolaus Harnoncourt | 9b891046-35af-4eb0-a058-eba4c9b8d01f |
| 16641 | Nikolaus Harnoncourt                         | 98b95966-64db-4631-8b9f-8aa66f32cc98 |
+-------+----------------------------------------------+--------------------------------------+

To reproduce

Steps to reproduce the behavior:

  1. Import a track with the metadata shown above.
  2. Check the names of the artists created

Expected behavior

Two artists are created, but the name of the first one should be only Concentus Musicus Wien. Even better, I think the name should be taken from Muscibrainz in the case the artist has a mbid, as is the case here.

Environment

  • Ampache version: 6.2.1 (but also seen in 5.6.0)
  • Web server + version: apache 2.4.57
  • Server operating system: Debian 12
  • Client operating system: Firefox 115 on Debian 12
@kuzi-moto
Copy link
Member

kuzi-moto commented Feb 20, 2024

Interesting, is this a duplicate of this issue? #2711

Supposedly it should have been fixed already, though I think I can confirm I still have issues where the artist name from albums with multiple artists are then incorrectly used for albums from just one of the artists as well.

@cquike
Copy link
Contributor Author

cquike commented Feb 21, 2024

Looks like a similar issue indeed. The difference in my case is that neither of the two album artist is the song artist. Maybe in that case the logic for fixing #2711 breaks?
As I mention in my tentative PR #3834 I think it is difficult to have some logic that woks in all cases correctly, with all possible artists separators. As @lachlan-00 mentions in #2711 (comment) the only reliable way is to use the mbid, which is what #3834 does (but not necessarily in a clean way :) ).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants