New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop support for python 3.5 #438
Conversation
Codecov Report
@@ Coverage Diff @@
## master #438 +/- ##
=======================================
Coverage 97.47% 97.47%
=======================================
Files 105 105
Lines 3290 3290
=======================================
Hits 3207 3207
Misses 83 83 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
||
**Breaking Changes** | ||
|
||
* Python 3.5 will not be actively supported. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sweeeet
@angela97lin RE your comment on 3.5-specific things: I see that 3.6 made dict sorting ordered by insertion by default. So I'm fine either way, as long as our test coverage ensures this to be true. Maybe a good separate PR. |
@dsherry Seems like it wouldn't hurt to keep in the OrderedDicts for now, so I won't change it quite yet (that way, py 3.5 users won't get different results even if we are not explicitly supporting 3.5 anymore)! |
Closes #435, dropping support for python 3.5.
Edit: do we also want to tackle removing any 3.5 specific things? (ex: OrderedDicts)