Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop support for python 3.5 #435

Closed
dsherry opened this issue Mar 2, 2020 · 8 comments · Fixed by #438
Closed

Drop support for python 3.5 #435

dsherry opened this issue Mar 2, 2020 · 8 comments · Fixed by #438
Labels
task Scripting, configuration, or other work which doesn't categorize well as a feature/enhancement/bug. testing Issues related to testing.

Comments

@dsherry
Copy link
Contributor

dsherry commented Mar 2, 2020

Should we drop python 3.5 support?

Numpy is dropping (or has dropped?) 3.5 support.

Doing so would mean we can close #167, as long as we're satisfied that bug is specific to 3.5 and not masking something else.

@kmax12
@dsherry dsherry added task Scripting, configuration, or other work which doesn't categorize well as a feature/enhancement/bug. testing Issues related to testing. labels Mar 2, 2020
@jeremyliweishih
Copy link
Contributor

Pandas only supports 3.6 and above as well.

@jeremyliweishih
Copy link
Contributor

I think Dask Distributed is the same.

@kmax12
Copy link
Contributor

kmax12 commented Mar 2, 2020

i'd say we're good to drop 3.5

@angela97lin angela97lin mentioned this issue Mar 3, 2020
Merged
@angela97lin
Copy link
Contributor

I'm going to make a PR for this (#438)!

@dsherry
Copy link
Contributor Author

dsherry commented Mar 3, 2020 •
edited

RE discussion in dev meeting, we don't know of any python 3.5 requirement

@dsherry
Copy link
Contributor Author

dsherry commented Mar 3, 2020

FWIW, it appears python 3.5 will get security fixes until Nov 2020. Numpy and pandas latest releases still claim to support 3.5. I'm still fine dropping now, just noting.

@kmax12
Copy link
Contributor

kmax12 commented Mar 3, 2020

@dsherry one thing, the latest pandas release is 1.0.1 (you linked to 0.24.0) and doesn't support.

@dsherry dsherry mentioned this issue Mar 3, 2020
Closed
@dsherry
Copy link
Contributor Author

dsherry commented Mar 3, 2020

🤦‍♂️of course, sorry! Pandas 1.0.1 doesn't support python 3.5, as @jeremyliweishih originally commented.

@alteryx alteryx deleted a comment from jeremyliweishih Aug 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
task Scripting, configuration, or other work which doesn't categorize well as a feature/enhancement/bug. testing Issues related to testing.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Drop support for python 3.5 alteryx/evalml
4 participants
@dsherry @kmax12 @angela97lin @jeremyliweishih