Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: updating nock library for node 18 #734

Merged
merged 1 commit into from
Apr 17, 2023
Merged

Conversation

bhardwz
Copy link
Contributor

@bhardwz bhardwz commented Apr 17, 2023

Changes the Nock library version to be compatible with node 18.

Description

Updated the nock version to 13.3.0,
Updated the testcase cases to be compatible with the latest package.

Motivation and Context

Build of ask-sdk-core was failing for node18, so updated the required package to pass the build.

Testing

Created local npm module of ask-sdk-core. Tested using the unit testcases.

Types of changes

  • [ x] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Docs(Add new document content)
  • Translate Docs(Translate document content)

Checklist

  • [ x] My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have read the README document
  • I have added tests to cover my changes
  • [ x] All new and existing tests passed
  • [ x] My commit message follows Conventional Commit Guideline

License

  • [ x] By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@bhardwz bhardwz requested a review from rahulawl April 17, 2023 08:47
@rahulawl rahulawl merged commit 47b5f29 into alexa:2.0.x Apr 17, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants