Merge pull request #734 from bhardwz/2.0.x

feat: updating nock library for node 18
alexa · Apr 17, 2023 · 47b5f29 · 47b5f29
2 parents f2bc574 + be6c8b0
commit 47b5f29
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 7 deletions.
diff --git a/ask-sdk-core/package.json b/ask-sdk-core/package.json
@@ -47,7 +47,7 @@
     "eslint": "^7.6.0",
     "eslint-plugin-tsdoc": "^0.2.6",
     "mocha": "^5.0.5",
-    "nock": "^9.2.3",
+    "nock": "^13.3.0",
     "nyc": "^14.1.1",
     "sinon": "^7.0.13",
     "ts-node": "^6.0.1",

diff --git a/ask-sdk-core/tst/service/DefaultApiClient.spec.ts b/ask-sdk-core/tst/service/DefaultApiClient.spec.ts
@@ -48,8 +48,7 @@ describe('DefaultApiClient', () => {
         expect(apiFake.isDone()).equal(true);
         expect(response.statusCode).equal(200);
         expect(response.body).equal('Success');
-        expect(response.headers[0]).deep.equal({key : 'v1', value : 'k_1'});
-        expect(response.headers[1]).deep.equal({key : 'v1', value : 'k_2'});
+        expect(response.headers[0]).deep.equal({key : 'v1', value : 'k_1, k_2'});
     });
 
     it('should be able to send GET request', async () => {
@@ -74,8 +73,7 @@ describe('DefaultApiClient', () => {
         expect(apiFake.isDone()).equal(true);
         expect(response.statusCode).equal(200);
         expect(response.body).equal('Success');
-        expect(response.headers[0]).deep.equal({key : 'v1', value : 'k_1'});
-        expect(response.headers[1]).deep.equal({key : 'v1', value : 'k_2'});
+        expect(response.headers[0]).deep.equal({key : 'v1', value : 'k_1, k_2'});
     });
 
     it('should be able to send DELETE request', async () => {
@@ -100,8 +98,7 @@ describe('DefaultApiClient', () => {
         expect(apiFake.isDone()).equal(true);
         expect(response.statusCode).equal(200);
         expect(response.body).equal('Success');
-        expect(response.headers[0]).deep.equal({key : 'v1', value : 'k_1'});
-        expect(response.headers[1]).deep.equal({key : 'v1', value : 'k_2'});
+        expect(response.headers[0]).deep.equal({key : 'v1', value : 'k_1, k_2'});
     });
 
     it('should be able to send PUT request', async () => {