Workaround for accent key composition in Chrome 53+ #3116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should fix ajaxorg#3027, ajaxorg#3045, ajaxorg#3097, ajaxorg#3100. Fix was identified by @hoge1e3 in ajaxorg#3045
|
Excuse me. Can this fix the problem? How to use it in ace.js? |
|
I have add the code， it works!! thank you~ |
Closed
|
@jpallen Is there any plan to release this fix as a public package (patch bump, probably)? |
This was referenced Dec 11, 2016
Closed
Gorash
added a commit
to odoo-dev/odoo
that referenced
this pull request
Mar 19, 2018
alexkuhn
pushed a commit
to odoo/odoo
that referenced
this pull request
Mar 20, 2018
Before this commit, there was an issue with input method using composition in which typed characters were duplicated. This was occuring until the composition ended. This is a bug specific to Google Chrome v53+. It has been fixed in the most recent version of ace.js [1], and we just port the fix into our custom code. Note that we do not simply import ace.js as a whole, because we must update lots of custom code at the same time. We plan to do so in the future. Fixes #23629 [1] ajaxorg/ace#3116
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #3027, #3045, #3097, #3100. Fix was identified by @hoge1e3
in #3045