Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chrome] Hangul has not been entered correctly. #3097

Closed
hangum opened this issue Sep 15, 2016 · 17 comments
Closed

[chrome] Hangul has not been entered correctly. #3097

hangum opened this issue Sep 15, 2016 · 17 comments

Comments

@hangum
Copy link

hangum commented Sep 15, 2016

Hangul typing from being updated to chromium 53.0.2785.116 version is abnormal.

Chrome : 53.0.2785.116 (64-bit)
image

@hangum hangum changed the title Hangul has not been entered correctly. [chrome] Hangul has not been entered correctly. Sep 15, 2016
@x-yao
Copy link

x-yao commented Sep 19, 2016

typing Chinese too

@hangum
Copy link
Author

hangum commented Sep 19, 2016

@x-yao Show them.

@mrdream24
Copy link

Chrome 52 work fine. This bug come when update Chrome 53

@mrdream24
Copy link

2016-09-21 13_49_47

@hangum
Copy link
Author

hangum commented Sep 21, 2016

@mrdream24 same problems.
my product is broken. I tested Chrome 54 is abnormal.

What do you think about this problem?

@mrdream24
Copy link

@hangum my product is broken,too.

I can't solve this problem

@hangum
Copy link
Author

hangum commented Sep 21, 2016

@mrdream24 my product is Tadpole DB Hub(https://tadpolehub.com/).
you?

@mrdream24
Copy link

@hangum 掘金

@hangum
Copy link
Author

hangum commented Sep 21, 2016

@mrdream24 thanks.

@mrdream24
Copy link

github use ace lib. has the same bug.

github

@hangum
Copy link
Author

hangum commented Sep 21, 2016

https://c9.io is same bug.

@anhh
Copy link

anhh commented Sep 21, 2016

I don't know why but i just commented "onCompositionUpdate function" in ace.js file. It works.

@hangum
Copy link
Author

hangum commented Sep 21, 2016

@anhh are you fix the problem?

@anhh
Copy link

anhh commented Sep 21, 2016

It seems like to work. I just tested hangul only. In the first line "onCompositionUpdate function", just put "return;" code.
It might have some side effects, but until now there is no side effect.

@hangum
Copy link
Author

hangum commented Sep 21, 2016

@anhh 감사합니다. 누구세요?

@hangum
Copy link
Author

hangum commented Sep 21, 2016

ace.js 파일의 부분을 다음과 같이 처리했습니다.
var onCompositionUpdate = function() {
// if (!inComposition || !host.onCompositionUpdate || host.$readOnly)
// return;
// var val = text.value.replace(/\x01/g, "");
// if (inComposition.lastValue === val) return;
//
// host.onCompositionUpdate(val);
// if (inComposition.lastValue)
// host.undo();
// inComposition.lastValue = val;
// if (inComposition.lastValue) {
// var r = host.selection.getRange();
// host.insert(inComposition.lastValue);
// host.session.markUndoGroup();
// inComposition.range = host.selection.getRange();
// host.selection.setRange(r);
// host.selection.clearSelection();
// }
};

처리 했을 경우 문제는
콤마를 입력하고 한글을 입력하다가 지우면 처음에 입력했던 콤마가 삭제되는 오류가 있네요.
예를들어 '한글테스트 라고 입력하는 중간에 뒤로 삭제하면 처음에 입력했던 콤마까지 삭제 되는 문제가 있습니다.

그래도 감사합니다. 임시 패치라도 내보내야겠네요.
누구신지 알려주시면 커피나 밥이라도 사고 싶습니다.

@hangum
Copy link
Author

hangum commented Sep 21, 2016

fixed
openatx-archive/atx-webide@69b478a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants