Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable support for TValue typing of ValueFormatterParams when using ValueFormatterFunc #5609

Open
wants to merge 1 commit into
base: latest
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 3 additions & 3 deletions community-modules/core/src/ts/entities/colDef.ts
Expand Up @@ -637,8 +637,8 @@ export interface ValueFormatterParams<TData = any, TValue = any> extends BaseCol
value: TValue;
}

export interface ValueFormatterFunc<TData = any> {
(params: ValueFormatterParams<TData>): string;
export interface ValueFormatterFunc<TData = any, TValue = any> {
(params: ValueFormatterParams<TData, TValue>): string;
}

export interface KeyCreatorParams<TData = any, TValue = any> extends BaseColDefParams<TData> {
Expand Down Expand Up @@ -715,4 +715,4 @@ export interface CellEditorSelectorResult {
popup?: boolean;
/** Equivalent of setting `colDef.cellEditorPopupPosition` */
popupPosition?: string;
}
}