New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable support for `TValue` typing of `ValueFormatterParams` when using `ValueFormatterFunc` #5609

Open

astorije wants to merge 1 commit into ag-grid:latest from astorije:patch-1

+3 −3

astorije commented Sep 27, 2022

At the moment, we use something like this:

const numericFormatter = ({
  value,
}: ValueFormatterParams<TData, number | undefined>) =>
  value === undefined ? '' : round(value, 2).toFixed(2);

This is great, but type safety can be improved a little further with this change:

const numericFormatter = ({
  value
}): ValueFormatterFunc<TData, number | undefined> =>
  value === undefined ? '' : round(value, 2).toFixed(2);


          Enable support for TValue typing of ValueFormatterParams when usi…

9605a26

…ng `ValueFormatterFunc`

gportela85 force-pushed the latest branch from 85c1a00 to 1ad15b1 Compare

March 1, 2023 04:27

salmenus force-pushed the latest branch from bb354db to dbaf62d Compare

August 14, 2023 13:30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment