Update README.md #5083
Open
Update README.md #5083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmarcos
reviewed
Jul 27, 2022
|
|
||
| :mag: **Visual Inspector**: A-Frame provides a built-in visual 3D inspector | ||
| with a workflow similar to a browser's developer tools and interface similar to |
There was a problem hiding this comment.
interface as in software interface is singular
dmarcos
reviewed
Jul 27, 2022
| Unity. Open up any A-Frame scene and hit `<ctrl> + <alt> + i`. | ||
|
|
||
| :runner: **Features**: Hit the ground running with A-Frame's built-in | ||
| components such as geometries, materials, lights, animations, models, | ||
| raycasters, shadows, positional audio, tracked controllers. Get even further |
There was a problem hiding this comment.
When a list is not exhaustive. Do you think the use of and can be confusing?
dmarcos
reviewed
Jul 27, 2022
| @@ -88,15 +88,15 @@ interactive WebVR experiences. | |||
|
|
|||
| :globe_with_meridians: **Cross-Platform**: Build VR applications for Vive, | |||
| Rift, Daydream, GearVR, and Cardboard. Don't have a headset or controllers? No | |||
| problem! A-Frame still works on standard desktop and smartphones. | |||
There was a problem hiding this comment.
when talking about software. we usually say this software is made for desktop and mobile. Singular is usually used.
|
Thanks! I'm not a great writer. Just made a few comments. Some changes like |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This README is pretty good overall, but I have some grammatical suggestions
Changes proposed: