Adding Custom Field Support #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hermeswaldemarin
force-pushed
the
feature/add-custom-fields-support
branch
from
61a541c
to
3d33e71
Compare
|
|
||
| public class ContextCustomFieldValue | ||
| { | ||
| public String Name { get; set; } |
There was a problem hiding this comment.
What's mapping the lower case names in the json to upper case in the code? Is it done automatically?
There was a problem hiding this comment.
Yes, magic. is the same in all other fields in Experiment class
hermeswaldemarin
force-pushed
the
feature/add-custom-fields-support
branch
from
3d33e71
to
8f8fe7c
Compare
bmsilva
approved these changes
Nov 29, 2023
hermeswaldemarin
force-pushed
the
feature/add-custom-fields-support
branch
6 times, most recently
from
1428d17
to
51a219e
Compare
hermeswaldemarin
force-pushed
the
feature/add-custom-fields-support
branch
from
51a219e
to
5570f23
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.