Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔒 fix vunerabilities #99

Merged
merged 1 commit into from Jun 12, 2019
Merged

🔒 fix vunerabilities #99

merged 1 commit into from Jun 12, 2019

Conversation

ClementVanPeuter
Copy link
Contributor

No description provided.

Copy link
Member

@hgwood hgwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you check that the app is compatible with firebase-admin v8? Isn't the app impacted at all by the breaking changes introduced in v7 and v8?

@hgwood hgwood self-requested a review June 12, 2019 08:59
@hgwood hgwood mentioned this pull request Jun 12, 2019
@hgwood
Copy link
Member

hgwood commented Jun 12, 2019

See #100 for break down of breaking changes. This PR should be safe.

@hgwood hgwood merged commit 979a202 into master Jun 12, 2019
@hgwood hgwood deleted the fix-vulnerabilities branch June 12, 2019 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants